Skip to content

Notification text should be white in night mode #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ShridharGoel opened this issue Dec 12, 2018 · 0 comments
Closed

Notification text should be white in night mode #2107

ShridharGoel opened this issue Dec 12, 2018 · 0 comments

Comments

@ShridharGoel
Copy link
Contributor

Summary:

Currently, the text in notifications in black in colour which is not easily readable. It should have been white.

Steps to reproduce:

  1. Switch to night mode.
  2. Go to Notifications.
  3. The text written in notifications is black in colour.

Commons app version:

2.9.0
Branch: master
Build: betaDebug

Screen-shots:

screenshot_2018-12-12-22-59-34-987_fr free nrw commons beta

Would you like to work on the issue?

Yes.
ShridharGoel added a commit to ShridharGoel/apps-android-commons that referenced this issue Dec 13, 2018
@ShridharGoel
Fix commons-app#2107 by changing notification text colour to white in…
9bed044 
… night mode
ShridharGoel added a commit to ShridharGoel/apps-android-commons that referenced this issue Dec 13, 2018
@ShridharGoel
Fix commons-app#2107 by changing notification text colour to white in…
0e3ca3e 
… night mode
@ShridharGoel ShridharGoel mentioned this issue Dec 13, 2018
Merged
ashishkumar468 added a commit that referenced this issue Dec 15, 2018
@ashishkumar468
Merge pull request #2110 from ShridharGoel/issue2107
6754ce1 
Fix #2107 by changing notification text colour to white in night mode
@domdomegg domdomegg mentioned this issue Dec 19, 2018
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShridharGoel