Skip to content

Fix #2107 by changing notification text colour to white in night mode #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2018

Conversation

ShridharGoel
Copy link
Contributor

Description (required)

Fixes #2107 Notification text should be white in night mode

Now, notification text in NotificationActivity will be white in colour when the app is in night mode.

Tests performed (required)

Tested betaDebug on API level 25.

Screenshot showing what has changed

img_20181213_211747

@codecov-io
Copy link

Codecov Report

Merging #2110 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2110      +/-   ##
=========================================
- Coverage     5.6%    5.6%   -0.01%     
=========================================
  Files         225     225              
  Lines       11379   11381       +2     
  Branches     1065    1066       +1     
=========================================
  Hits          638     638              
- Misses      10689   10691       +2     
  Partials       52      52
Impacted Files Coverage Δ
...nrw/commons/notification/NotificationRenderer.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2175ba2...0e3ca3e. Read the comment docs.

@ashishkumar468 ashishkumar468 merged commit 6754ce1 into commons-app:master Dec 15, 2018
@ShridharGoel ShridharGoel deleted the issue2107 branch December 16, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants