Skip to content

Inconsistent usage of Utils.isDarkTheme #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
domdomegg opened this issue Dec 21, 2018 · 0 comments · Fixed by #2268
Closed

Inconsistent usage of Utils.isDarkTheme #2214

domdomegg opened this issue Dec 21, 2018 · 0 comments · Fixed by #2268
Assignees
@domdomegg
Labels
code-quality

Comments

@domdomegg
Copy link
Member

Summary:

There is Utils.isDarkTheme() however it is not used consistently throughout the project. It should be, to avoid duplicated code and be able to easily find usages.

Would you like to work on the issue?

Yes. Has conflicts with #2213 so will wait for that to be merged first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domdomegg domdomegg

Labels
code-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2214: Use Utils.isDarkTheme consistently through app
1 participant
@domdomegg