Skip to content

Refractor feature Review #2915

@ashishkumar468

Description

@ashishkumar468

Summary:
The architectures of the layout files of ReviewActivity and ReviewFragment are not the best. 1. Instead of putting the scroll view in the activity_review, the scroll view could be in just the review_fragment, with only the question and question context being scrollable, as in instead of making the whole page scrollable, only the content which can actually scroll should be allowed to scroll, This could also be a probable fix for #2908
2. The naming conventions of views in xml, replace camel case with underscore based naming convention.
3. The ImageInfo icon on the toolbar, should have been a menu icon instead of an actually ImageButton over the toolbar
4. Use ButterKnife to handle OnClicks and View bindings wherever possible.
5. TextViews with dummy data should have used tools:text instead of android: text

Would you like to work on the issue?
Yes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions