Fix #2915 Refractor feature Review

[ashishkumar468]

Description (required)
Fixes #2915 Refractor feature Review

What changes did you make and why?
As mentioned in the issue thread, made the following changes

• Refractor ReviewActivity and ReviewImageFragment and the related layout files, to properly use the scrollview
• Use ButterKnife for ViewBindings in ReviewImageFragment
• updated resource id names to follow underscore notation in xml
• Use menu item instead of ImageView over toolbar in ReviewActivity
• use tools:replace instead of android:text for dummy texts

Tests performed (required)

Tested betaDebug on Samsung S7 with API level 26
.

Screenshots showing what changed (optional - for UI changes)

[codecov-io]

Codecov Report

Merging #2916 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2916      +/-   ##
=========================================
+ Coverage    3.62%   3.64%   +0.01%     
=========================================
  Files         246     244       -2     
  Lines       12209   12190      -19     
  Branches     1077    1078       +1     
=========================================
+ Hits          443     444       +1     
+ Misses      11732   11712      -20     
  Partials       34      34

Impacted Files	Coverage Δ
...r/free/nrw/commons/review/ReviewImageFragment.java	0% <0%> (ø)	⬆️
...ava/fr/free/nrw/commons/review/ReviewActivity.java	0% <0%> (ø)	⬆️
app/src/main/java/fr/free/nrw/commons/Media.java	6.41% <0%> (-0.49%)	⬇️
...fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.java	0.86% <0%> (-0.01%)	⬇️
...rw/commons/mwapi/ApacheHttpClientMediaWikiApi.java	0% <0%> (ø)	⬆️
.../commons/contributions/ContributionViewHolder.java	0% <0%> (ø)	⬆️
...fr/free/nrw/commons/media/MediaDetailFragment.java	0% <0%> (ø)	⬆️
.../fr/free/nrw/commons/category/GridViewAdapter.java	0% <0%> (ø)	⬆️
...w/commons/explore/images/SearchImagesRenderer.java	0% <0%> (ø)	⬆️
...ommons/contributions/ContributionsListAdapter.java	0% <0%> (ø)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17d69cd...2af31f9. Read the comment docs.

[neslihanturan]

Hi @ashishkumar468 , this PR absolutely improves the code quality. Thanks for polishing the code. My only critique is for UI, to compare before and after:

I think before look is better ie bigger buttons.

[neslihanturan]

I approve the code quality, but I have added some comments in terms of UI.

[neslihanturan]

We discussed with @ashishkumar468 in private: Here is what we conclude:

Bigger text sizes are better in terms of UI but we want to keep it single line too. Forcing to single line is not an option since button names would be unclear in such case. Cleanest option (without implementing hacky codes) is leaving the implementation as @ashishkumar468 does now, then reconsidering button names, as already suggested in #2873

Additionally, @ashishkumar468 can you please fix all capital strings for button names, and capitalize them programatically, ie:
<string name="review_category_yes_button_text">NO, MIS-CATEGORIZED</string>

[ashishkumar468]

@neslihanturan Thanks for pointing it out NES, have made the relevant changes .

[neslihanturan]

Thanks @ashishkumar468 will merge after tests passed

[ashishkumar468]

Thanks for merging the PR @neslihanturan.