Skip to content

Achievement crashes when GetWikidataEditCountResponse is null. #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ashishkumar468 opened this issue Jun 5, 2019 · 0 comments · Fixed by #2994
Closed

Achievement crashes when GetWikidataEditCountResponse is null. #2993

ashishkumar468 opened this issue Jun 5, 2019 · 0 comments · Fixed by #2994

Comments

@ashishkumar468
Copy link
Collaborator

Summary:

Achievement crashes when GetWikidataEditCountResponse is null.

Steps to reproduce:
Not sure how to reproduce this, @neslihanturan Shared the logcat.

System logs:

2019-06-04 15:41:05.182 5218-5218/fr.free.nrw.commons E/AchievementsActivity: Error:java.lang.NullPointerException: Attempt to invoke virtual method 'int fr.free.nrw.commons.wikidata.model.GetWikidataEditCountResponse.getWikidataEditCount()' on a null object reference

Commons app version:
2.10.2

Would you like to work on the issue?
Yes
ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue Jun 5, 2019
@ashishkumar468
BugFix commons-app#2993
f272299 
* Added null check on countResponse in OkHttpJsonApiClient$getWikidataEdits
@ashishkumar468 ashishkumar468 mentioned this issue Jun 5, 2019
Merged
maskaravivek pushed a commit that referenced this issue Jun 5, 2019
@ashishkumar468 @maskaravivek
BugFix #2993 (#2994)
06dbfef 
* Added null check on countResponse in OkHttpJsonApiClient$getWikidataEdits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BugFix #2993 ashishkumar468/apps-android-commons
1 participant
@ashishkumar468