Skip to content

Conversation

@ashishkumar468
Copy link
Collaborator

Description (required)

What changes did you make and why?

  • Added null check on countResponse in OkHttpJsonApiClient$getWikidataEdits

Tests performed (required)

Tested ProdDebug on Samsung S7, API level 27

* Added null check on countResponse in OkHttpJsonApiClient$getWikidataEdits
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


Check the status or cancel PullRequest code review here.

@codecov-io
Copy link

Codecov Report

Merging #2994 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2994      +/-   ##
=========================================
- Coverage    3.69%   3.69%   -0.01%     
=========================================
  Files         249     249              
  Lines       12270   12271       +1     
  Branches     1090    1091       +1     
=========================================
  Hits          453     453              
- Misses      11782   11783       +1     
  Partials       35      35
Impacted Files Coverage Δ
...fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.java 0.84% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aabcd0e...f272299. Read the comment docs.

@maskaravivek maskaravivek merged commit 06dbfef into commons-app:master Jun 5, 2019
@ashishkumar468 ashishkumar468 deleted the bugfix/npe-in-wikidatacount branch June 5, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Achievement crashes when GetWikidataEditCountResponse is null.

3 participants