Skip to content

Category search does not work properly [current master] #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
misaochan opened this issue Jun 20, 2019 · 4 comments
Closed

Category search does not work properly [current master] #3027

misaochan opened this issue Jun 20, 2019 · 4 comments
Labels

Comments

@misaochan
Copy link
Member

Summary:

Searching for the exact category name does not output any results even though that category exists.

Steps to reproduce:

I searched for "Christchurch Botanic" and was told "No Categories Found". However that exact category does exist as per my search of only "Christchurch".

Screenshot_1561017509
Screenshot_1561017541

System logs:

Sorry, forgot to collect logs but it is 100% reproducible for me, so if you have difficulty reproducing I can collect them again.

Device and Android version:

Nexus S API 27 emulator, AND Samsung Galaxy S9

Commons app version:

Current master 2.10.2.452

@nicolas-raoul
Copy link
Member

I noticed this too, it is a very recent problem.
Screenshot_20190619-140838_Commons

@ashishkumar468
Copy link
Collaborator

Thanks for finding the issue @misaochan and @nicolas-raoul , I will look into it :-)

ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue Jun 23, 2019
* Clear previous categories search result only when the new search results are non-empty
@ashishkumar468
Copy link
Collaborator

ashishkumar468 commented Jun 23, 2019

@misaochan I tried manually calling the api's with "Christchurch Botanic", for which I get the response

<allcategories>
<c xml:space="preserve">Christchurch Botanic Gardens</c>
</allcategories>

And the app as expected shows the search result for the same.
device-2019-06-23-160042

But for the search term christchurch botanic g, I actually gets 0 response from the api's

<query>
<allcategories/>
</query>
</api>

The keywords are case sensitive, and that is why, although Christchurch Botany has some results, but christchurch botanic g does not have any

@misaochan
Copy link
Member Author

A recap of my conversation with Ashish: It actually looks like the first letter of the first word is not case-sensitive, but the others are. That would explain both my and @nicolas-raoul 's findings.

We are planning to look at the old category implementation (prior to the upload process overhaul) to see how this was handled previously, since this issue appears to be new (but to the best of our knowledge the API hasn't changed).

ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue Jul 18, 2019
* Concat category search with search with image title list and default categories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants