Skip to content

Closes #3027 #3080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2019
Merged

Conversation

ashishkumar468
Copy link
Collaborator

Description (required)

Fixes #3027 Category search does not work properly [current master]

What changes did you make and why?
Concatenate category search with search with image title list and search all

Tests performed (required)

Tested ProdDebug on S7 with API level 27.

Screenshots showing what changed (optional - for UI changes)

device-2019-07-19-010555

* Concat category search with search with image title list and default categories
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov-io
Copy link

codecov-io commented Jul 20, 2019

Codecov Report

Merging #3080 into 2.11-release will increase coverage by <.01%.
The diff coverage is 7.4%.

Impacted file tree graph

@@               Coverage Diff               @@
##           2.11-release   #3080      +/-   ##
===============================================
+ Coverage          4.41%   4.42%   +<.01%     
===============================================
  Files               259     259              
  Lines             12310   12335      +25     
  Branches           1056    1058       +2     
===============================================
+ Hits                544     546       +2     
- Misses            11727   11749      +22     
- Partials             39      40       +1
Impacted Files Coverage Δ
.../free/nrw/commons/repository/UploadRepository.java 0% <0%> (ø) ⬆️
.../fr/free/nrw/commons/category/CategoriesModel.java 0% <0%> (ø) ⬆️
...nrw/commons/repository/UploadRemoteDataSource.java 0% <0%> (ø) ⬆️
...ns/upload/categories/UploadCategoriesFragment.java 0% <0%> (ø) ⬆️
...commons/upload/categories/CategoriesPresenter.java 72.58% <66.66%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32715d9...a7d6c19. Read the comment docs.

@misaochan
Copy link
Member

Thanks @ashishkumar468 !

@misaochan misaochan merged commit 8cd9bd5 into commons-app:2.11-release Jul 21, 2019
@ashishkumar468 ashishkumar468 deleted the bugfix/categories branch July 21, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants