-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Showcase featured images #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I like the idea of having a list of recently featured images. Personally, though,I wouldn't really want it at the top of the gallery. After I upload a pic, I like to glance at the top pic of the gallery to check that the upload has completed, etc. I also like to be able to quickly check what the last couple of photos I uploaded was, without having to scroll. Perhaps we could just have it as an additional activity, so users can decide whether to view it or not? |
I would like a gallery of featured pictures, if it is a separate item in the nav drawer (https://material.io/guidelines/patterns/navigation-drawer.html). That way it only loaded if a user specifically wants to look at the gallery. |
I agree, having it in a nav drawer would be great. I think I started an attempt at creating a nav drawer for the app, but hit some bugs that I couldn't resolve (see #251 ) |
Now that we have a nav drawer, what do you guys think about implementing this (possibly as part of the renewal)? @neslihanturan @maskaravivek |
@nicolas-raoul , do you know if there is an API for this? |
I think it is just a normal category. I am sure there is an API to get all media of a category. |
Ah okay, thanks! |
This will be implemented in the later half of the IEG renewal. The scope is still somewhat vague, so we need to discuss how the UI will look like, what exactly to display, etc. Use case: Scope:
|
+1 for Contributions view |
Since I really liked this idea, maybe we can add it on third tab along with contributions, nearby, instead of another item on nav drawer. |
While working on mockups of this feature, some question come up: |
I would personally not be in favour of 3 tabs - I think 2 is enough, too many would distract the user from our main focus. IMO this would be better as an item in the nav drawer instead of a tab.
|
Here are three suggestion of me for featured pictures. I would go with 3rd one since we want to encourage users to take better pictures to be in this list one day, displaying user names on first sight could help our purpose. Besides since I don't want any license violations, here are attributions from top left corner:
|
Looks good to me! I would be good with Option 3, but I think we need to find a way to show more clearly that the bottom text is the author. Perhaps a more significant difference in font between the top and bottom text? |
Even if visually option 1 is best, I prefer option 3 for our purpose. Would tapping a picture show its details view with description/categories? Featured images always have proper categories, which could serve as a good example to follow. |
Actually I tried to fit categories to this page too, but there is no enough space. I agree adding Uploaded by indicator. And yes, I will send some media details sketch today. |
How about reusing the existing media details view, with just the added
field "author"?
…On Fri, Nov 10, 2017 at 3:28 PM, neslihanturan ***@***.***> wrote:
Actually I tried to fit categories to this page too, but there is no
enough space. I agree adding Uploaded by indicator. And yes, I will send
some media details sketch today.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#324 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGFBgxK4Bj69j5-_LeMKmOF9IDXmmnKks5s0-0NgaJpZM4KyPIs>
.
|
I remember some discussions about existing media details view here #873 . So maybe we need to redesign it for both featured and contributions view. What do you think @nicolas-raoul ? |
Yes the two will probably have much in common.
…On Nov 10, 2017 18:10, "neslihanturan" ***@***.***> wrote:
I remember some discussions about existing media details view here #873
<#873> . So
maybe we need to redesign it for both featured and contributions view. What
do you think @nicolas-raoul <https://github.com/nicolas-raoul> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#324 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGFBkwqdI2k8Ioo1xUI5_0C_vofEAq5ks5s1BMPgaJpZM4KyPIs>
.
|
I definitely wouldn't try and fit categories into the grid layout, haha. It would be way too cramped IMO. I also agree with adding "Uploaded by", and using the same media details UI for contributions and featured. However, if we do add the ability for users to modify their desc etc inside the app, that needs to be restricted solely to contributions (no concrete plans for that yet until 2018 though). |
So should we leave UI improvements for media detail to 2018 too? This would make me very happy though because I am having hard times to choose a design currently:) |
I did some research on finding list of images in a particular category. But was unable to find that API. instead we can use API:Images to find all images in a particular page. Also I think most of the images from Category:Featured_pictures_on_Wikimedia_Commons |
Can I work on this issue? |
Hi @ujjwalagrawal17 , did you noticed the UI is already ready on another branch. And the rest is in our IEG plans. Besides, if you feel ready to start a non-beginner friendly task please go for it:) I will assign it to you. |
Hi @ujjwalagrawal17 , sorry, we would like to be able to assign this issue to you, but it is already in our IEG plans for the next few months. Please do take a look at one of our other issues, thanks. :) |
@misaochan ok no problem I will look at other issues. 😄 |
Just a wild idea, looking forward to your feedback about it:
How about putting a "List of recently featured images" at the top of the gallery? Scrollable to the left/right.
Plus:
Minus:
The text was updated successfully, but these errors were encountered: