Develop ui featured images

[neslihanturan]

This PR includes UI for featured images (last pic of the days) as discussed here #324
I thought I have added screenshots already, @misaochan , here they are:

[codecov-io]

Codecov Report

Merging #1051 into featuredImages will decrease coverage by 0.06%.
The diff coverage is 0%.

@@                Coverage Diff                @@
##           featuredImages   #1051      +/-   ##
=================================================
- Coverage            3.64%   3.58%   -0.07%     
=================================================
  Files                 112     116       +4     
  Lines                5235    5334      +99     
  Branches              487     490       +3     
=================================================
  Hits                  191     191              
- Misses               5031    5130      +99     
  Partials               13      13

Impacted Files	Coverage Δ
.../fr/free/nrw/commons/di/FragmentBuilderModule.java	0% <ø> (ø)	⬆️
.../fr/free/nrw/commons/di/ActivityBuilderModule.java	0% <ø> (ø)	⬆️
...fr/free/nrw/commons/media/MediaDetailFragment.java	0% <0%> (ø)	⬆️
...free/nrw/commons/theme/NavigationBaseActivity.java	22.22% <0%> (-0.77%)	⬇️
...w/commons/featured/FeaturedImagesListFragment.java	0% <0%> (ø)
...free/nrw/commons/featured/MockGridViewAdapter.java	0% <0%> (ø)
...ee/nrw/commons/media/MediaDetailPagerFragment.java	0% <0%> (ø)	⬆️
...va/fr/free/nrw/commons/featured/FeaturedImage.java	0% <0%> (ø)
...e/nrw/commons/featured/FeaturedImagesActivity.java	0% <0%> (ø)
...free/nrw/commons/upload/MultipleShareActivity.java	0% <0%> (ø)	⬆️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7c248...d0f07f2. Read the comment docs.

[misaochan]

@neslihanturan Nice! Do you think we could get screenshots for the PR? :)

[misaochan]

Hi @neslihanturan , sorry it took so long for me to go through this. The screenshots you posted look good to me, with one minor issue: there needs to be an "Author" field in the detailed (individual) view, as mentioned at #324 . :)

Will also ping @psh for feedback.

[misaochan]

Needs "author" field in media details view, see comment.

[psh]

I have no problems with the UI as it stands. The behavior and the overall look + feel are incredibly similar to the ContributionsActivity though, especially when you get to the launching of the MediaDetailPagerFragment and all the interaction. I imagine there is going to be a lot of duplication between classes contribution and featured views once we're done.

Yes, the will be the addition of the "author" field in this version of the media detail view, but does that justify copying / duplicating most of the classes? Is there an opportunity to (a) reuse code and (b) take the time to improve it as we go?

[neslihanturan]

Thanks for feedback @psh , this was one of my concerns while implementing it. But I thought it can be too much for this PR (I mean refactoring ContributionActivity also). But I totally agree that we need to reuse these codes.

Besides, what would you think if featured images UI wouldn't be incredibly similar to ContributionActivity? We should make user feel she is on a different activity (the only disciriminator is activity title currently).

[neslihanturan]

Added author field @misaochan , and tested. It worked fine for me on 4.4.2, for both activities (No author field on Contribution), orientation changes included. Here is the screenshot:

[misaochan]

Thanks @neslihanturan ! I agree that refactoring the code to prevent duplication would be great. However, I will go ahead and merge this PR first, please feel free to submit the refactoring in another PR. :)