Skip to content

Starting Uploads notification not dismissing #3981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
madhurgupta10 opened this issue Oct 22, 2020 · 22 comments · Fixed by #3983 or #4099
Closed

Starting Uploads notification not dismissing #3981

madhurgupta10 opened this issue Oct 22, 2020 · 22 comments · Fixed by #3983 or #4099
Assignees
Labels

Comments

@madhurgupta10
Copy link
Collaborator

Summary:
Starting Uploads notification not dismissing.

I installed the app on a new device and the notification was automatically triggered even when there were no pending uploads and I am unable to dismiss it.

Device and Android version:
Xiaomi A2 API 29

Commons app version:
2.13.1-debug-master-409e43c3a prodDebug latest master

Screen-shots:
Screenshot_20201022-145328

@sivaraam
Copy link
Member

I'm experiencing this for quite some time now. Currently I can reproduce this using v2.13.1.809~409e43c of the app that I installed from the Play store alpha channel on a Android 5.1.1 device. I have to force stop the app to make the notification go away. I'm suspecting this was introduced after the introduction of the limited-network mode option in PR #3934.

@madhurgupta10
Copy link
Collaborator Author

@sivaraam same behaviour for me, the only way to dismiss the notification is by force stopping the app.

Pinging @maskaravivek for discussion on this issue.

ashishkumar468 added a commit to ashishkumar468/apps-android-commons that referenced this issue Oct 24, 2020
* Start the upload service when needed and not in the MainActivity directly
maskaravivek pushed a commit that referenced this issue Oct 26, 2020
* Start the upload service when needed and not in the MainActivity directly
@madhurgupta10
Copy link
Collaborator Author

@ashishkumar0207 @sivaraam Unfortunately the issue still exists for me (2.13.1-debug-master~c793827c5) when I toggle Limited Connection Mode.

@madhurgupta10 madhurgupta10 reopened this Oct 31, 2020
@nicolas-raoul
Copy link
Member

I uninstalled then reinstalled the app (alpha/master) yesterday and had this notification run for hours, even though I did not enable Limited Connection mode.

@misaochan
Copy link
Member

Same here, it also started happening much more frequently for me on the current master.

@Prince-kushwaha
Copy link
Contributor

This issue is not solved in the master branch
I want to work on this issue

@ashishkumar468
Copy link
Collaborator

@Prince-kushwaha Sure, go ahead, please post updates over here :)

@Prince-kushwaha
Copy link
Contributor

assigness me for this issue

@Prince-kushwaha
Copy link
Contributor

@ashishkumar0207 can review my pull request #4041 and #4028

@misaochan
Copy link
Member

I merged your other PRs. :) Please feel free to work on this now @Prince-kushwaha .

@ashishkumar468
Copy link
Collaborator

Hi @Prince-kushwaha are you still working on this?

@Prince-kushwaha
Copy link
Contributor

Yes

@Prince-kushwaha
Copy link
Contributor

Make PR in few days

@ashishkumar468
Copy link
Collaborator

@Prince-kushwaha Thanks for the update, how are you planning to approach the issue?

@Prince-kushwaha
Copy link
Contributor

  • fixes automatically triggered of Upload then their is no Pending of uploads of media
  • fixes notification that is not dismissing

@Prince-kushwaha
Copy link
Contributor

Not able to solve this issue completly

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Dec 1, 2020

@Prince-kushwaha No problem, just commit and push your code into a branch on your repository and link to it here so that others can have a look :-) Also please feel free to share here any tips or things you have noticed. Thanks for your work!
Do you want to be unassigned and work on another issue, or do you want to keep trying on this one, asking for advice along the way?

@Prince-kushwaha
Copy link
Contributor

Any one explain me how Uploading of media work in this app

@Prince-kushwaha
Copy link
Contributor

on install latest branch
there is many bugs regarding uploads

@ashishkumar468
Copy link
Collaborator

Hi @Prince-kushwaha , are you still working on this one?

@Prince-kushwaha
Copy link
Contributor

Yes

@misaochan
Copy link
Member

misaochan commented Dec 10, 2020

@Prince-kushwaha could you tell us specifically what you have tried and where you are stuck, please? Unfortunately the questions you are asking are very general and I'm not sure how we can help you with them. :/

If you feel that you would prefer to work on a different issue, you are most welcome to do so, just let us know. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants