Skip to content

Fix issue where upload notification shows up on app start #4099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

maskaravivek
Copy link
Member

Description (required)

Fixes #3981

Tests performed (required)

  • Tested that app doesn't show this notification when there are no pending uploads
  • when an upload is started, the notification appears

@codecov-io
Copy link

Codecov Report

Merging #4099 (53165c3) into master (7d8e09f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4099      +/-   ##
============================================
- Coverage     10.59%   10.59%   -0.01%     
  Complexity      476      476              
============================================
  Files           343      343              
  Lines         12887    12896       +9     
  Branches       1001     1001              
============================================
  Hits           1366     1366              
- Misses        11453    11462       +9     
  Partials         68       68              
Impacted Files Coverage Δ Complexity Δ
...ree/nrw/commons/contributions/ContributionDao.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...java/fr/free/nrw/commons/upload/UploadService.java 0.81% <0.00%> (-0.04%) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8e09f...53165c3. Read the comment docs.

@misaochan misaochan merged commit 5c6e777 into commons-app:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting Uploads notification not dismissing
3 participants