Skip to content

Delete Old UI Tests? #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
madhurgupta10 opened this issue Dec 6, 2020 · 7 comments
Closed

Delete Old UI Tests? #4073

madhurgupta10 opened this issue Dec 6, 2020 · 7 comments
Assignees
@Roshan13046
Labels
discussion tests

Comments

@madhurgupta10
Copy link
Collaborator

Summary:
Capture
@domdomegg
Copy link
Member

I support removing the tests if they don't even compile. We haven't been running these instrumentated tests in so long it'd be great to see them fixed or removed so we can get them running in Travis again.

@domdomegg domdomegg added the tests label Dec 6, 2020
@misaochan
Copy link
Member

Agreed, we need to either fix or remove these.

@Roshan13046
Copy link
Contributor

Can I fix this issue?
My Approach: Deleting the old UI tests from the file.
Any suggestions?

@misaochan
Copy link
Member

I think it's OK to delete for now. We should probably make a separate issue for writing UI tests that actually work.

@madhurgupta10
Copy link
Collaborator Author

@Roshan13046 Feel free to make a PR for this issue!

@Roshan13046
Copy link
Contributor

@Roshan13046 Feel free to make a PR for this issue!

Please, suggest to me which UI tests are considered old UI tests?

Roshan13046 added a commit to Roshan13046/apps-android-commons that referenced this issue Feb 5, 2021
@Roshan13046
Fixes:commons-app#4073 Old UI tests deleted.
ee16a2e
@Roshan13046 Roshan13046 mentioned this issue Feb 5, 2021
Merged
neslihanturan pushed a commit that referenced this issue Feb 16, 2021
@Roshan13046
Fixes:#4073 Old UI tests related with nav menu and user icon are dele…
a8bbd41 
…ted. (#4213)
@madhurgupta10
Copy link
Collaborator Author

Fixed in #4828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Roshan13046 Roshan13046

Labels
discussion tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nicolas-raoul @misaochan @domdomegg @madhurgupta10 @Roshan13046