Skip to content

5279: Target the latest Android version #5296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RitikaPahwa4444
Copy link
Collaborator

Description (required)

Fixes #5279

What changes did you make and why?
Changed targetSdkVersion and compileSdkVersion.

Tests performed (required)

Tested prodDebug on Redmi 5A with API level 27.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great (tested with 2 uploads on Android 14).
Unit tests passing.

@nicolas-raoul nicolas-raoul merged commit f577053 into commons-app:main Sep 19, 2023
@nicolas-raoul
Copy link
Member

Sorry I had not tested resetting the app, it seems to break upload :'-( #5297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target the latest Android version
2 participants