-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add support for campaigns #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
things to customize in a campaign as opposed to normal usage of the app:
anything else? |
We are discussing the possibility of implementing this at #865 . Copying over my comment from that thread, so that we can discuss it here: There are varying levels of "support" possible, ranging from simply displaying news/ads for ongoing campaigns, to full integration that allows users to submit photos for the competitions directly through the app. Personally I would start with the former, and wait and gauge the response before trying for the latter. While a central app for submitting WLM, WLE, etc submissions sounds great, AFAIK the winners and perhaps even most of the participants of such competitions tend to primarily use DSLRs and not mobile phones to take their pictures? My assumption could be incorrect, though, would greatly appreciate feedback on that. :) |
While winners (and, right, most of the participants) surely use other equipment to take pictures, we have troublesome regions frome where it would be a blessing for wlm-ua to have even phone-taken picture of a monument. (Not like I am sure that having an app will 100% resolve this, though. Or know anything about other countries.) |
[off-topic] @AtaZh Is wikilovesmonuments.org.ua maintained by your community? It seems to have been hacked. |
I would like to take our campaigns implementation forward. BackgroundIt was initially implemented by @nicolas-raoul and then removed later by @misaochan (Ref #13 and #26) Current stateAs part of WMCZ @ashishkumar468 added support for showing news about campaigns. (Ref #78) Proposed extensionWith our current upload infra, it would be trivial to support in-app uploads for images under a campaign.
I am eager to take this up and can assure you that it won't add any unnecessary complexity to the app. Why?
Opinions @nicolas-raoul @misaochan @neslihanturan @ashishkumar468? |
Great, good luck! |
The banner can have CTA for uploading ie gallery and camera buttons. If all these buttons can't be accommodated in a single line then we can have an expandable card similar to the nearby list.
It won't apply to all subsequent uploads. The categories/templates would be added only when an upload is initiated using the campaign banner. Similar to nearby uploads where the wiki data item is linked only from nearby map/list.
For uploading unrelated pictures, you would have to go back.
wasn't planning to add a selector in the upload wizard. When the user comes on the category screen, the campaign category would be auto-selected but he can deselect it. The campaign template would be appended only if the campaign category was selected.
Do you mean internationalization/localization for banner text or something else? Banner text localization and other things for internationalization are important but can be picked as a separate task. :) My plan is to add this feature with minimum changes so that we do not add any extra complexity to the flows. After #888 and #1092 we can start handling more complex scenarios. :) |
Ah, gallery/camera buttons on the banner is a good idea indeed! :-) |
Sorry I missed this. It sounds like a great idea, @maskaravivek ! :) We should hardcode a dummy campaign in the development branch to test the flow before we release it, though. |
Have created #2793 which I'll work on. |
Hey all, finally this is happening :) Today I worked on some mockups and ideas about how to implement WLM. Here they are:
You can see the whole flow with mockups below. Technical appoach and possible issues
Metrics
|
Yup, we are super stoked to be working on implementing WLM integration into the app for WLM 2021, as part of our new project grant! :) Integration of other types of campaigns are not in scope for the time being, but we should be able to generalize more in the future. Generally speaking, this is the process that we intend to go through:
Thank you for the quick and detailed mockups, @neslihanturan !
I don't think this is our call to make, we should ask the organizers what they think about this. I will ping them and ask.
I like the idea of a banner, and the one in the mockup looks great! I think that searching for the active countries is excessive complexity however, as AFAIK most countries hold WLM at the same time every year (with the exception of 2020 due to Covid). For instance, what happens if someone is searching at the boundary between 2 countries, 1 with WLM active and 1 with WLM inactive? Personally I would just have the banner up all the time and everywhere during Sep 2021, saying something like "It's Wiki Loves Monuments month! (Learn more)". If the user is browsing a country that isn't participating in WLM, there will just not be WLM markers up for them.
I think that WLM encourages multiple submissions for each monument, I don't think they discourage submissions if there is already a picture up (pinging @nicolas-raoul @VojtechDostal for comment on this). Therefore for WLM specifically I would vote to always display WLM icon.
I like this idea, but I think it would be more visible to have it as a "Place state" chip next to Exists and Needs Photo.
Love the cat. ;) The monuments that are curated for WLM would already have the recommended title and description in their Wikidata properties I believe.
Yes, from Wikidata.
Great idea, I agree.
Nice!
Yup, exactly. It may also be worth noting that we were discussing on the WLM mailing list as to which data source was to be used - the monuments database (that is co-maintained by Jean-Frederic) or Wikidata. Jean-Frederic himself, alongside Maarten Dammers/Multichill and several others, have voted quite unanimously for Wikidata. https://lists.wikimedia.org/pipermail/wikilovesmonuments/2020-July/009263.html |
Uploads are always welcome, "Needs picture" or not, WLM or not :-) |
AFAIK it is allowed to join WLM, whether you are at the place or not. You can upload pictures taken beforehand.
Good idea, and will be simpler to implements
I agree, thumbnails may discourage people from uploading. Lets make all of them with WLM logo.
Hmm, place type is more visible indeed. However there is few space there. If we add one more filter as WLM, it may go two lines. But we can live with it.
What I meant was categories like "Images from Wiki Loves Earth 2020", "Images from Wiki Loves Earth 2020 in Turkey". I am not sure if they are listed at somewhere or if do they rely on a standard. Also, I am not sure if Wikidata items has a category information necessarily. This is an example item from Wiki Loves Earth 2020 in Turkey:
Meanwhile I learned from my local community that every year a different template is being used (the same one for all countries) with language code next to it. For example: {{Wiki Loves Earth 2020|tr}}
Agreed. |
According to latest discussions, here is the final (for now) mockups: Here is the commons upload: https://commons.wikimedia.org/wiki/File:Commons_Android_Application_Wiki_Loves_Monuments_entegration_mockups.png |
The mockups and implementation plans are being discussed at https://commons.wikimedia.org/wiki/Commons:Mobile_app/WLM currently. We will take community feedback until 8 March, at which point we will modify the plans/design as needed and re-post the finalized plans. |
Finalized plans for WLM 2021Scope: Users should be able to upload photos for the WLM competition via Nearby, with the monument ID and appropriate template attached. We should complete implementation by 1 July 2021 to allow time for testing. Implementation: (See mockups above for reference)
Testing & publicity:
|
Hi @misaochan , Quick question around this - as far as I understand, we will be using this API - https://heritage.toolforge.org/api/ to get the monuments around an area. An entry in the response looks like this I am not able to figure out the upload part - as in using what entity-identifier will we be querying the wiki-data for these entries? |
I believe |
Hi @ashishkumar468 , as mentioned at #545 (comment) , the WLM coordinators have recommended that we not use the monuments database as our source, but rather Wikidata. In the mailing list discussion that I linked, the comments from Multichill and Jean-Frederic were:
and
So I believe that rather than using https://heritage.toolforge.org/api/ , we are to query Wikidata for items where a monument ID (P2186) exists, instead. I can confirm on the mailing list if you like. What do you think @nicolas-raoul ? |
@misaochan I haven't read this whole discussion but I agree that Wikidata are superior to monument lists. As for P2186 as the filter for monuments, please be aware that this will only work for countries which use this identifier property: For example, as you can see, this will not work for Czechia because we don't use P2186 in our monuments - we have official identifiers such as P4075. Is there an official policy by WLM organizers that we should adopt P2186, eg. by copying over values from P4075? If yes, I'll happily do that - such harmonization might be a good idea - but I'd like to know what is the community standpoint on that. |
Ah, thanks for the input @VojtechDostal ! Is there a way to easily access a list of which identifiers each country uses for their monuments? |
There's at least some in this table (column Identifier property): https://www.wikidata.org/wiki/Wikidata:WikiProject_WLM/Status#Table I am not sure if such long list of properties would be easily "queriable"... On the other hand, including all of them would probably greatly increase number of countries able to use the app. |
Great to hear that this database got deprecated in favor of Wikidata! I am all for doing everything with Wikidata, obviously 🙂 |
If anyone is interested in following the discussion, it is at https://lists.wikimedia.org/pipermail/wikilovesmonuments/2021-April/subject.html , or you can subscribe to wikilovesmonuments@lists.wikimedia.org for updates. For the time being there is a wide range of different opinions, so I'll give it a bit more time to see if a trend emerges. |
So, we got a lot of good ideas from the responses, however some of them (e.g. Magnus's suggestion of a new tool acting as an interface, or Platonides's suggestion of the Wikidata table) are beyond our scope as Android developers, and we are also very rapidly approaching our end of June beta testing deadline. :/ I'm thinking that for this year, we should move ahead with P2186, otherwise we risk not having anything at all by the time WLM rolls around. Then in the future (would be a great GSoC project I reckon) we could add enhancements that would include more countries in our map, like the suggestions above, or Philip's suggestion of letting the user choose their identifier if needed. |
Edit: Additionally, #3410 is slated for release in the same version as WLM, so I guess that could be a stopgap measure for experienced users for the time being. |
It seems that the WLM community is largely split on whether P2186 or P1435 should be used as the property identifier (mailing list discussion). The benefits of P1435 are that it is a tried and tested method (used by other tools e.g. Monumental) and appears fairly future-proof, but the disadvantages are that it is a broad designation which includes sites that aren't eligible for WLM (e.g. natural heritage sites). The benefits of P2186 are that it offers national organizers more control over which sites they do or don't want to be included in the map (as mentioned by the national organizers themselves), however some members of the community feel that it is a "hack" that should be deprecated soon and that they want the community to move away from using it. I think we should carry on with our work and keep an eye on the community discussion. Regardless of which one is chosen, switching to the other later should be fairly simple. |
- Add query for monuments - Make API call to fetch monuments - Attach the list of monuments with nearby places response and render the monumens on the Map along with other nearby items
Update: I held an office hour with WLM organizers on 27 May. Turns out there are more complications with using one property identifier than we foresaw, and the WLM organizers feel very strongly about this. Stephen La Porte mentioned that he might be able to help out by creating a .json file for us with the desired property for each country, which they would maintain for us. We accepted and are now in the process of hashing out the finer details. As this change involves a different property identifier for each country, that means the SPARQL query would vary depending on the search coordinates. Due to this, we are going to postpone #3410 to the next release, to minimize potential conflicts and difficulties with debugging. |
Hi @misaochan, I had some more doubts
Now that we would be fetching the properties from the JSON, should we expect the properties for the P31(location) and that for the address (P669, P670) to change too?
If we do implement this, what exactly would the shared content look like? |
Hi @ashishkumar468 ,
The JSON would only give us a list of which property identifier we should search for. In the example that Stephen gave us via email, Basically the JSON only replaces the search for P1435 or P2186, by telling us which identifier is needed for each country. Everything after that point, i.e. the captions and descriptions, remains the same as planned. For the time being, while we wait for the JSON, we can just use P1435 and implement everything else first.
Actually I think we can give this a skip for now and only implement it later on if there is time, since it's optional (and also nobody was particularly interested in it when I talked about it during the WLM office hours, lol). Better to focus on other things first. |
From the wlm mailing list,
So now instead of 1 "WLM month", there are 2 months and countries can pick any 30 days in those months for their contest. This will be tricky to implement, but I guess we can just display the WLM markers from 1 Sep to 31 Oct. |
Hi @misaochan , I had a question around templates, so from the link you've added, a sample template looks like
The other things we can get from the query response, but what about this, "Cultural Heritage Russia", how do we decide what goes in this for different monuments at different locations? |
Hi @misaochan . Do you mean to say we completely hide the markers for WLM if the date is not between 1st Sep to 31st Oct?. Also will we not be showing a banner on home screen those days? |
- Add query for monuments - Make API call to fetch monuments - Attach the list of monuments with nearby places response and render the monumens on the Map along with other nearby items
Yes exactly. Or rather, we revert to the existing state of our Nearby map outside those dates. Take care not to just "hide the WLM markers" as some of them are the same as existing Nearby pins, so they should just revert to normal pin status. I would probably approach this by not running the additional WLM query at all outside those dates, It would be nice if there was a way for us to test without changing system date. Perhaps just a boolean flag whose value that we can toggle when debugging. |
Hi @VojtechDostal and @nicolas-raoul , we've encountered a couple of issues that we hope you can help us with.
Thanks a lot. :) |
Sorry I have no insight on 1 and 2. |
Hmm, okay, thanks. Looking at https://commons.wikimedia.org/wiki/File:Queensland_-_Stanthorpe_Post_Office_-_20210425163522.jpg which was uploaded through Monumental, there seems to be no WLM template added at all, which is rather perplexing? I'll ask on the mailing list... |
- Add query for monuments - Make API call to fetch monuments - Attach the list of monuments with nearby places response and render the monumens on the Map along with other nearby items
Unfortunately the JSON tool by volunteers did not materialize. I suggested to the WLM organizers, and they accepted, that we will simply follow Monumental's strategy, which is to simply filter for certain properties everywhere, and display the union of it - https://github.com/hatnote/monumental-wlm/blob/master/src/components/main/map/map.js#L139 . @VojtechDostal , I just realized that we can do a bit better than that and just add P4075 manually to the query, for Czechia. It should be a one-line change. Will you guys be participating in WLM 2021? If you are, will you be interested in having us add that property? |
* Integrate WLM - Show monuments in maps along with nearby * BugFix in Monuments 1. Single preference for monuments and campaigns 2. Expand collapse chips container in nearby 3. Typo fix in Monuments card in Nearby 4. If a nearby place is a monument as well - do not show them separately, show it as a monument instead 5. Bug fix, monument radius, use the same one as that of nearby * More bug fixes 1. Possible NPE in nearby 2. Added column location_address in BookmarkLocationDao 3. Bug Fix - Display Date in WLM card 4. WLM card on click takes to nearby * Use lowercase country code in WLM uploads * Bug-Fix, WLM Campaign Icon * 1. Updated monuments query to use any of the following properties for monuments - [P1435, P2186, P1459, P1460, P1216, P709, P718, P5694] 2. Append WikiData QID to descriptions template * Updated WLM Banner String, Handle NPE in contributions callback * Added nearby-monuments query log lines * Handle WLM Query exception : - if an exception is thrown in WLM query, continue showing the nearby items if that succeeds * Fix BookmarkLocationDaoTest * Added Column Address in BookmarkLocationDaoTest * Use fallback description as usual nearby pins even for WLM pins, instead of relying on P6375 * Test fix in BookmarkLocationDao * Updated template for WLM, removed redundant feilds * Fixed WLM template * Removed categories from WLM template * Fixed BookmarkControllerTest * Fixed BookmarkLocationFragmentUnitTest * fix ModelFunctions * Fixed BookmarksDaoLocationTest * Fixed WLM template
Reopening this as there is a bit more work to be done before campaigns can be released. |
Due to its complexity, I have listed the current task list/timeline for the actual WLM release. For reference for @ashishkumar468 , @neslihanturan , and anyone who is interested:
|
https://commons.wikimedia.org/wiki/File:Haight-Ashbury_2.jpg uploaded today with the full implementation. Public beta coming up real soon! :) |
Out in beta. Great job everyone! 🚀 |
Upload campaigns for specific events have aditional fields and automaticaly add templates and categories.
Right now WLE campaign is running, e.g. https://commons.wikimedia.org/w/index.php?title=Special:UploadWizard&campaign=wle-ua
Is it possible to add support for them?
The text was updated successfully, but these errors were encountered: