Skip to content

UI to display notifications #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

neslihanturan
Copy link
Collaborator

@neslihanturan neslihanturan commented Dec 20, 2017

Hi team, I implemented a sketch for notifications activity. Currently I manually entered some notifications, of course NotificationController class needs to fetch notifications from servers. This PR can be considered an UI implementation and a rough structural implementation.

Fix for #7 , here is how it looks:
device-2017-12-20-205304

@codecov-io
Copy link

Codecov Report

Merging #1024 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1024      +/-   ##
=========================================
- Coverage    3.71%   3.66%   -0.05%     
=========================================
  Files         104     109       +5     
  Lines        5143    5210      +67     
  Branches      489     491       +2     
=========================================
  Hits          191     191              
- Misses       4939    5006      +67     
  Partials       13      13
Impacted Files Coverage Δ
.../fr/free/nrw/commons/di/ActivityBuilderModule.java 0% <ø> (ø) ⬆️
...nrw/commons/notification/NotificationActivity.java 0% <0%> (ø)
...free/nrw/commons/theme/NavigationBaseActivity.java 22.98% <0%> (-0.83%) ⬇️
...mmons/notification/NotificationAdapterFactory.java 0% <0%> (ø)
...fr/free/nrw/commons/notification/Notification.java 0% <0%> (ø)
...nrw/commons/notification/NotificationRenderer.java 0% <0%> (ø)
...w/commons/notification/NotificationController.java 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45ff21...7abb530. Read the comment docs.

@misaochan
Copy link
Member

@neslihanturan Awesome! Yes, please feel free to create a new branch and submit the PR to it. :)

@neslihanturan neslihanturan changed the base branch from master to uıForNotifications December 21, 2017 09:58
@maskaravivek
Copy link
Member

Am going ahead and merging this PR so that I can take it forward from here.

@maskaravivek maskaravivek merged commit 031e53c into commons-app:uıForNotifications Jan 7, 2018
misaochan added a commit to misaochan/apps-android-commons that referenced this pull request Jan 16, 2018
…yNotificationsUI"

This reverts commit 031e53c, reversing
changes made to 0aa20ef.

revert UI notifications
maskaravivek pushed a commit to maskaravivek/apps-android-commons that referenced this pull request Jan 21, 2018
…n/displayNotificationsUI""

This reverts commit d253db5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants