-
Notifications
You must be signed in to change notification settings - Fork 1.3k
UI to display notifications #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI to display notifications #1024
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
=========================================
- Coverage 3.71% 3.66% -0.05%
=========================================
Files 104 109 +5
Lines 5143 5210 +67
Branches 489 491 +2
=========================================
Hits 191 191
- Misses 4939 5006 +67
Partials 13 13
Continue to review full report at Codecov.
|
@neslihanturan Awesome! Yes, please feel free to create a new branch and submit the PR to it. :) |
Am going ahead and merging this PR so that I can take it forward from here. |
…n/displayNotificationsUI"" This reverts commit d253db5.
Hi team, I implemented a sketch for notifications activity. Currently I manually entered some notifications, of course NotificationController class needs to fetch notifications from servers. This PR can be considered an UI implementation and a rough structural implementation.
Fix for #7 , here is how it looks:
