Feature/switch to butterknife #1505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hishkumar468/apps-android-commons into feature/switch_to_butterknife
…commons into feature/switch_to_butterknife
…commons into feature/switch_to_butterknife
Codecov Report
@@ Coverage Diff @@
## master #1505 +/- ##
=========================================
+ Coverage 3.14% 3.14% +<.01%
=========================================
Files 136 136
Lines 7381 7366 -15
Branches 714 711 -3
=========================================
Hits 232 232
+ Misses 7134 7119 -15
Partials 15 15
Continue to review full report at Codecov.
|
maskaravivek
approved these changes
May 10, 2018
There was a problem hiding this comment.
Looks good to me! Can be merged after testing once on a real device.
Thanks @ashishkumar468 for your contributions. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing ButterKnife in the classes in which it is not already there [issue #1491]
Did the required changes in ShareActivity, SimilarImageDialogFragment, MultipleUploadListFragment [Package uploads wrapped up]
Tests performed
Tested on {21 & name of Android SDK built for x86_64}, with {build variant, debug}.