-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Refactor ShareActivity #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ShareActivity #1552
Conversation
…l' into upload-overhaul-fork
…ent to ShareActivity as well
…pload-overhaul-fork
Codecov Report
@@ Coverage Diff @@
## master #1552 +/- ##
=========================================
+ Coverage 3.86% 3.87% +0.01%
=========================================
Files 149 150 +1
Lines 7576 7556 -20
Branches 721 708 -13
=========================================
Hits 293 293
+ Misses 7266 7246 -20
Partials 17 17
Continue to review full report at Codecov.
|
@maskaravivek @neslihanturan This is now ready for review. :) I believe it will make fixing #1485 easier after this is merged, as ShareActivity will be more manageable. |
…pload-overhaul-fork # Conflicts: # app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested both Nearby uploads and normal upload flow. It works perfectly. Thanks, @misaochan for taking up the refactoring. :)
Fixes #1091 . Tested by uploading via app and "share" on prodDebug build, real device running Android 7.0.
Changes made:
Directed all upload entry points to ShareActivity. MultipleShareActivity.java will be removed completely in a future PRThis redirection cannot be done yet if we are to release 2.8 with this PR.