Get rid of legacy URL

[urbanecm]

This URL still works but intended as legacy.
As there are more separate API endpoints,
I've renamed the folder to commonsmisc to
enable me to add all endpoints to one folder
and to reduce potentional damage that can be caused
by fogotting the symlink is there for a reason,
I'm renaming it in the Commons app as well

[urbanecm]

I OF COURSE do not plan to delete the symlink right after this will be merged, it will exist for some "switching period" to ensure all users use updated version.

[codecov-io]

Codecov Report

Merging #1646 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1646   +/-   ##
======================================
  Coverage    3.85%   3.85%           
======================================
  Files         151     151           
  Lines        7595    7595           
  Branches      711     711           
======================================
  Hits          293     293           
  Misses       7285    7285           
  Partials       17      17

Impacted Files	Coverage Δ
...rw/commons/mwapi/ApacheHttpClientMediaWikiApi.java	4.98% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2de1a...e2d4224. Read the comment docs.

[misaochan]

Happy to merge after this has been tested. :)

@urbanecm What length do you intend for the "switching period"? IMO I would give it at least a year, as Android users are never really required to update their apps. When looking through current uploads, I see many older versions of the app being used.

[nicolas-raoul]

(off topic: we should also make sure the app does not get stuck even with "urbanecmbot/some/random/path/to/nonexisting.py")

[urbanecm]

I plan to watch access.log and as soon as almost no accesses to the old location are made, I will turn it down. As of now, I do not have a time plan. An year or even more is not a problem.

Is there manual testing necessary? I don't know how to build an android app from code, I just replaced the text.

[misaochan]

@urbanecm Sounds good to me.

You don't need to build the app, one of us will test it (once we sort out our backlog...) and we will merge it once our testing passes. :)

[misaochan]

@nicolas-raoul Should we just default to 0 in that case?

[urbanecm]

@misaochan Ok, thank you for explanation Josephine :).

[nicolas-raoul]

How about null and disabling that whole message if null?
But if just displaying a number is an easier fix, I would go for "-1" to make it clear it is an application error.

[sivaraam]

How about null and disabling that whole message if null?

Disabling the whole message seems to be a nice solution.

But if just displaying a number is an easier fix, I would go for "-1" to make it clear it is an application error.

By means, showing a number (even if it's -1) when we don't have contribution info, seems to be a bad idea. Not showing at all should be nice.

[neslihanturan]

This works for me. With my personal account it displays correct number. I also have a zero uploads test account on production server, it displays "0" as expected. I think we can merge this, please revert if you think I am wrong:)