Add feature to Browse commons via app #1716

ujjwalagrawal17 · 2018-07-14T12:12:21Z

Title (required)

Fixes Allow users to browse Commons from app #1221 (Allows users to browse commons from app)

Description (required)

Improvements in category images activity (Changed it to explore activity)
added search activity with 2 fragments (one for searching images, other for categories)
Added recent Search history and delete recent search hostory feature
Added a category details page (includes media, subcategories, parent categories inside that category)

Tests performed (required)

Manually Tested on API 25 & MOTO G5S+, with {ProdDebug variant}.

Screenshots showing what changed (optional)

Fixes #1521 (Search activity, image search feature added.)

Rename featured Image to explore

…-via-app

… finished the process of mocking the main component for tests.

…ity-principle is maintained in CategoryApi.

* Add option to set image as wallpaper * Added java docs * Toast message on setting the wallpaper successfully

nicolas-raoul · 2018-07-18T09:10:00Z

app/src/main/java/fr/free/nrw/commons/category/CategoryDetailsActivity.java

+        context.startActivity(intent);
+    }
+
+    @Override


There are still many methods without Javadoc it seems, such as these ones.
Please add Javadoc to all of them, thanks! :-)

@nicolas-raoul Ok, I will search and do it for all.

@nicolas-raoul I have added it for most of the methods now. Can you tell if we need it in any other method/class?

…s-android-commons into browse-commons-via-app

…android-commons into browse-commons-via-app

ujjwalagrawal17 · 2018-07-23T09:01:03Z

@nicolas-raoul Can we merge #1737 it will fix the conflicts between 2 branches.

ujjwalagrawal17 · 2018-07-23T09:02:00Z

@nicolas-raoul @neslihanturan Also, can you both review it once for any other changes.

app/src/main/java/fr/free/nrw/commons/category/CategoryImagesActivity.java

app/src/main/java/fr/free/nrw/commons/category/CategoryImagesListFragment.java

neslihanturan · 2018-07-23T10:14:18Z

Looks very clean @ujjwalagrawal17 , nice job!

ujjwalagrawal17 · 2018-07-23T18:33:35Z

@neslihanturan @nicolas-raoul can we merge it now ??

nicolas-raoul

I reviewed and tested a lot again, it is all good!

@misaochan Is it OK to merge the browse feature into master now?

misaochan · 2018-07-24T07:13:26Z

Go for it! Thanks everyone who participated in this. :)

neslihanturan · 2018-07-24T07:17:17Z

Congratz!

domdomegg · 2018-11-01T20:06:08Z

Can this branch be deleted now?

misaochan · 2018-11-04T09:15:59Z

I think so. Can @ujjwalagrawal17 confirm?

ujjwalagrawal17 · 2018-11-04T09:22:52Z

Yes, @misaochan it can be deleted now. We can add other browse features directly in master.

ujjwalagrawal17 and others added 30 commits May 28, 2018 14:03

Search activity, image search fragment added

75f5f1b

Removed explore icon xml

5bb1d19

Updated Javadocs for search Activity and Navigation Base Activity

2aac404

SearchImageItem class updated

021905a

Javadocs added for search activity

4422329

removed redundant code and added javadocs for search image modules

092d2a3

Javadocs added for updateImageList method

a5d67cc

Merge pull request #1561 from ujjwalagrawal17/search_activity

df82383

Fixes #1521 (Search activity, image search feature added.)

Rename featuredImage to explore

98b3d69

Merge pull request #1568 from ujjwalagrawal17/rename_featured

f1d5bb0

Rename featured Image to explore

Merge remote-tracking branch 'main_origin/master' into browse-commons…

be49f90

…-via-app

Fixed null query issue

dd4f42f

changed cisibility to gone in case of successful Fetch

b3816f1

Consolidate the networking libraries - drop volley in favor of OkHttp

fb51ae7

Extracted a few networking related items into a new Dagger module and…

417fdc0

… finished the process of mocking the main component for tests.

Refactoring to extract GpsCategoryModel and ensure single-responsibil…

85b474b

…ity-principle is maintained in CategoryApi.

fixed featured image back bug

e8f3849

Localisation updates from https://translatewiki.net.

dfd4d2a

Javadocs added

4b7e1e2

Add option to set image as wallpaper (#1535)

5643352

* Add option to set image as wallpaper * Added java docs * Toast message on setting the wallpaper successfully

Localisation updates from https://translatewiki.net.

ba5d0ac

SearchHistory Fragment added

deb8b53

Search History Item added

1978f0a

Content Provider, RecentSearchesDao added

b84105e

Database version changed to 7 and added methods for find, save ,..

ae09445

Delete icon deleted

948ce05

Reverted changes in gradle files

0b95deb

Reverted changes in gradle files 2

177f8a8

Optimized Improts

8c68944

reverted refractor for container name

19378e3

nicolas-raoul reviewed Jul 18, 2018

View reviewed changes

ujjwalagrawal17 and others added 2 commits July 18, 2018 16:09

More javadocs added for explore Feature

093b317

Merge branch 'feat_borwse_javadocs' of github.com:ujjwalagrawal17/app…

ffe5b19

…s-android-commons into browse-commons-via-app

commons-app deleted a comment Jul 18, 2018

ujjwalagrawal17 added 3 commits July 23, 2018 13:54

Javadocs added

9e4f8be

Javadocs added

1249afe

Merge branch 'browse-commons-via-app' of github.com:commons-app/apps-…

ba0109e

…android-commons into browse-commons-via-app

commons-app deleted a comment Jul 23, 2018

Fixed conflicts

7462df4

commons-app deleted a comment Jul 23, 2018

neslihanturan reviewed Jul 23, 2018

View reviewed changes

app/src/main/java/fr/free/nrw/commons/category/CategoryImagesActivity.java Show resolved Hide resolved

neslihanturan reviewed Jul 23, 2018

View reviewed changes

app/src/main/java/fr/free/nrw/commons/category/CategoryImagesListFragment.java Outdated Show resolved Hide resolved

neslihanturan reviewed Jul 23, 2018

View reviewed changes

app/src/main/java/fr/free/nrw/commons/category/CategoryImagesListFragment.java Show resolved Hide resolved

Improvements in indentation (#1739)

11b13be

commons-app deleted a comment Jul 23, 2018

nicolas-raoul approved these changes Jul 24, 2018

View reviewed changes

neslihanturan merged commit 86878fb into master Jul 24, 2018

misaochan mentioned this pull request Jul 24, 2018

Quiz #1629

Merged

nicolas-raoul mentioned this pull request Aug 3, 2018

Nearby edits didn't edit Wikidata items #1601

Closed

misaochan deleted the browse-commons-via-app branch November 4, 2018 09:33

domdomegg mentioned this pull request Dec 21, 2018

Add search via voice option in app #1640

Open

Add feature to Browse commons via app #1716

Add feature to Browse commons via app #1716

Uh oh!

Conversation

ujjwalagrawal17 commented Jul 14, 2018

Title (required)

Description (required)

Tests performed (required)

Screenshots showing what changed (optional)

Uh oh!

nicolas-raoul Jul 18, 2018

Choose a reason for hiding this comment

Uh oh!

ujjwalagrawal17 Jul 18, 2018

Choose a reason for hiding this comment

Uh oh!

ujjwalagrawal17 Jul 18, 2018

Choose a reason for hiding this comment

Uh oh!

ujjwalagrawal17 commented Jul 23, 2018

Uh oh!

ujjwalagrawal17 commented Jul 23, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neslihanturan commented Jul 23, 2018

Uh oh!

ujjwalagrawal17 commented Jul 23, 2018

Uh oh!

nicolas-raoul left a comment

Choose a reason for hiding this comment

Uh oh!

misaochan commented Jul 24, 2018

Uh oh!

neslihanturan commented Jul 24, 2018

Uh oh!

domdomegg commented Nov 1, 2018

Uh oh!

misaochan commented Nov 4, 2018

Uh oh!

ujjwalagrawal17 commented Nov 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants