-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix urgent crashes A and E #1749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
misaochan
merged 55 commits into
commons-app:2.8-release
from
neslihanturan:fixUrgentCrashesAandE4
Aug 1, 2018
Merged
Fix urgent crashes A and E #1749
misaochan
merged 55 commits into
commons-app:2.8-release
from
neslihanturan:fixUrgentCrashesAandE4
Aug 1, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from contributions list.
… from nearby list and map
…l save the file to a internal path and it will be deleted by another method after upload process is done.
…e, instead of Contributions.getLocalUri which was Uri from content provider
…om temporarily saved file, insdeat of the Uri from content provider.
… sure if it is useless or not. Requires discussion
…ame file and access old file reference. It was a weird problem though
Ready to be tested @misaochan :) |
Just tested this. All of my tests work and the wrong image bug seems to have been fixed, great job! :) A Nearby upload failed once, but the next upload I tried via the same method succeeded, so that was probably just a fluke. |
This was referenced Aug 6, 2018
This was referenced Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes A and E from #1545 (I hope). It saves file which is being uploaded to a temp location, and uses Uri of that file as reference during upload process, instead of using Uri that content provider supported.
Tests performed (required)
Tested on API 23, beta debug. Tested actions: share photo from another application, share multiple photos from another application and contributing via contributions list.
Not: Finally a beautiful commit history!