Request Title When Title Empty In Multi-Upload Share #1769
Conversation
…ulting to the English version. Tested with Spanish on physical Android device. Other notes: Difficulties building with gradle due to dexcount plugin: KeepSafe/dexcount-gradle-plugin#234. In testing, disabled the plugin.
There was a problem hiding this comment.
Thanks for the PR @albendz. The changes look good to me. :)
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
=========================================
- Coverage 3.63% 3.63% -0.01%
=========================================
Files 182 182
Lines 9154 9157 +3
Branches 795 796 +1
=========================================
Hits 333 333
- Misses 8799 8802 +3
Partials 22 22
Continue to review full report at Codecov.
|
|
It works, thanks! |
|
Yeah, I will make a new string set. I figured we wouldn't have time to do translations for the release so I used the existing string. Do you have instructions on creating new string sets? |
|
I don't think we have instructions, just edit strings.xml :-) |
|
Ah, I mean what is the process to request translations? |
|
You don't have to do anything :-) |
|
PR for new string: #1771 |
Title (required)
Fixes Multiple Uploads crashes if user try to upload without title #1734
Description (required)
Fixes Multiple Uploads crashes if user try to upload without title #1734
As in the single upload case, provide a check that validates the title field and displays a toast if title is not provided.
Tests performed (required)
Tested on {API 24 Android 7.0 Physical Device Samsung Nexus S6
Screenshots showing what changed (optional)