Skip to content

Request Title When Title Empty In Multi-Upload Share #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 31, 2018
Merged

Request Title When Title Empty In Multi-Upload Share #1769

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71cbc90
Try to get the localized version of the wikipedia article before defa…
albendz Apr 15, 2018
17786a0
Update article fetch to not include unnecessary SERVICE line
albendz May 1, 2018
83980a9
Merge branch 'master' of git://github.com/commons-app/apps-android-co…
albendz Jun 23, 2018
c547c42
Merge remote-tracking branch 'upstream/master'
albendz Jul 4, 2018
7ee6691
Merge remote-tracking branch 'upstream/master'
albendz Jul 30, 2018
6aa0f25
Provide toast to request title in multi upload share when title is empty
albendz Jul 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/src/main/java/fr/free/nrw/commons/upload/MultipleUploadListFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import android.widget.GridView;
import android.widget.RelativeLayout;
import android.widget.TextView;
import android.widget.Toast;

import butterknife.BindView;
import butterknife.ButterKnife;
Expand Down Expand Up @@ -205,6 +206,10 @@ public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
public boolean onOptionsItemSelected(MenuItem item) {
switch (item.getItemId()) {
case R.id.menu_upload_multiple:
if (baseTitle.getText().toString().trim().isEmpty()) {
Toast.makeText(getContext(), R.string.add_title_toast, Toast.LENGTH_LONG).show();
return false;
}
multipleUploadInitiatedHandler.OnMultipleUploadInitiated();
return true;
}
Expand Down