Fix failed uploads

[maskaravivek]

Title (required)

Fixes #1485

Will add the description if this actually fixes the issue. :)

@nicolas-raoul @misaochan Can you help in testing this.

For me:

• I was able to reproduce the issue where image upload started failing with mustbeloggedin error.
• I kept tweaking a few things while retrying the same upload and was running into authentication issues.
• Finally the retrial failed with a different error. I am assuming this is an unrelated error.

<?xml version="1.0" encoding="UTF-8"?><api servedby="mw1284"><error code="verification-error" info="File extension &quot;.John's_National_Academy_of_Health_Sciences&quot; does not match the detected MIME type of the file (image/jpeg)."><details><detail>filetype-mime-mismatch</detail><detail>John's_National_Academy_of_Health_Sciences</detail><detail>image/jpeg</detail></details><docref xml:space="preserve">See https://commons.wikimedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &amp;lt;https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce&amp;gt; for notice of API deprecations and breaking changes.</docref></error></api>

• I upload a new image and it uploads successfully.

[misaochan]

This works for me!!!!! Well done @maskaravivek , you have solved a bug that has stumped us for over a month!! 🥇 👏 👍

I experienced a couple of minor issues while testing:

• I think this needs to be rebased on 2.8-release and submitted to 2.8-release. I noticed some bugs with new changes on master (the desc language selector) while testing it
• While the new uploads succeed, I don't get the usual upload progress bar in ContributionsActivity. It just says "Queued" until it succeeds, even if there is no other upload ongoing. However this might be due to a bug on master, so it would be worth doing the rebase first and then seeing if it persists

[codecov-io]

Codecov Report

Merging #1790 into 2.8-release will increase coverage by 0.01%.
The diff coverage is 4.92%.

@@              Coverage Diff               @@
##           2.8-release   #1790      +/-   ##
==============================================
+ Coverage         3.64%   3.66%   +0.01%     
==============================================
  Files              186     188       +2     
  Lines             9318    9478     +160     
  Branches           825     839      +14     
==============================================
+ Hits               340     347       +7     
- Misses            8954    9107     +153     
  Partials            24      24

Impacted Files	Coverage Δ
...ava/fr/free/nrw/commons/mwapi/CustomApiResult.java	0% <0%> (ø)
.../java/fr/free/nrw/commons/auth/SessionManager.java	10% <0%> (-0.72%)	⬇️
...java/fr/free/nrw/commons/upload/UploadService.java	0% <0%> (ø)	⬆️
...n/java/fr/free/nrw/commons/auth/LoginActivity.java	0% <0%> (ø)	⬆️
...ain/java/fr/free/nrw/commons/auth/AccountUtil.java	0% <0%> (ø)	⬆️
...ree/nrw/commons/auth/WikiAccountAuthenticator.java	0% <0%> (ø)	⬆️
...free/nrw/commons/theme/NavigationBaseActivity.java	22.11% <100%> (ø)	⬆️
...rw/commons/mwapi/ApacheHttpClientMediaWikiApi.java	3.66% <4%> (-0.1%)	⬇️
...in/java/fr/free/nrw/commons/mwapi/CustomMwApi.java	8.04% <8.04%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e32f8d3...708ec07. Read the comment docs.

[misaochan]

Thanks for the fixes, @maskaravivek . I tested this again on a separate emulator, and the progress bar is fixed now. :) I am unable to test on the emulator with failed uploads due to the rebase - it requires an uninstall due to the recent contentprovider change, and I can't reproduce failed uploads if I uninstall.

So, I am in favour of merging this once the Travis build completes. :) Then we can release this to beta, and see if it fixes the issue for the users who are experiencing failed uploads.

If I'm not around when Travis completes, anyone please feel free to squash and merge.

[maskaravivek]

@misaochan The build was failing because of a test failure.

[maskaravivek]

Merging this as both checks are now passing. :)