Skip to content

Feature/bug fix#1793 #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 16, 2018
Merged

Feature/bug fix#1793 #1802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6004d7c
bug fix, locales not showing up in the spinner in ShareActivity [issu…
ashishkumar468 Aug 6, 2018
dc51632
Merge branch 'master' into feature/bug_fix#1793
ashishkumar468 Aug 6, 2018
d45ca99
removed extra padding from the languages edit text in the spinner
ashishkumar468 Aug 16, 2018
064a46c
Merge branch 'master' of https://github.com/commons-app/apps-android-…
ashishkumar468 Aug 16, 2018
2e233a4
reduced weight percentage of spinner to 30% and increased that of the…
ashishkumar468 Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/src/main/res/layout/row_item_description.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,17 @@
xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content"
xmlns:tools="http://schemas.android.com/tools"
android:orientation="horizontal"
android:weightSum="10">

<android.support.v7.widget.AppCompatSpinner
android:id="@+id/spinner_description_languages"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_gravity="center_vertical"
android:layout_weight="3"
tools:listitem="@layout/row_item_languages_spinner"
android:spinnerMode="dialog"></android.support.v7.widget.AppCompatSpinner>

<android.support.design.widget.TextInputLayout
Expand Down
11 changes: 7 additions & 4 deletions app/src/main/res/layout/row_item_languages_spinner.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,23 @@
<LinearLayout
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/ll_container_description_language"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:padding="10dp"
android:id="@+id/ll_container_description_language"
android:orientation="vertical">
<TextView
android:id="@+id/tv_language"
style="@style/Base.TextAppearance.AppCompat.Widget.TextView.SpinnerItem"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:padding="4dp"
android:paddingTop="10dp"
android:paddingBottom="10dp"
android:paddingLeft="4dp"
android:paddingRight="4dp"
android:imeOptions="flagNoExtractUi"
android:maxLines="1"
style="@style/Base.TextAppearance.AppCompat.Widget.TextView.SpinnerItem"
android:singleLine="true"
android:textAlignment="center"
tools:text="en"
/>

Expand Down