Add Traceur for getting meaningful RxJava stack traces #1832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.8-release #1832 +/- ##
==============================================
+ Coverage 3.63% 3.64% +0.01%
==============================================
Files 188 188
Lines 9543 9544 +1
Branches 843 843
==============================================
+ Hits 347 348 +1
Misses 9172 9172
Partials 24 24
Continue to review full report at Codecov.
|
|
@misaochan I have updated the base for this PR. It can be merged in the |
|
Thanks! |
maskaravivek
added a commit
that referenced
this pull request
Sep 7, 2018
* Add Traceur for getting meaningful RxJava stack traces (#1832) * Hotfix for overwrite issue in 2.8.0 (#1838) * This solution is an hotfix for overrite issue came back on 2.8.0 version. What I did is checking the extension, and if it is null, adding .jpg suffix. Because commons files always have suffixes, and we should compare file names after adding suffixes. Othervise overrides are possible. * Check if file title includes an extension already, by checking if is there any dot in it. * Fix logic error * Add uncovered tests * Remove unecessary line breaks * Make Javadocs more explicit * Versioning and changelog for v2.8.2 (#1842) * Versioning for v2.8.2 * Changelog for v2.8.2 * Add logs in wiki data edit and session refresh flow (#1874) * Fix logout (#1875) * [WIP] Refactor feedback and quiz to reduce possibility of NPE (#1881) * Refactor feedback and quiz to reduce possibility of NPE * Handle throwables in quiz checker * Minor refactoring * Set Traceur to only work in DEBUG mode (#1884) * Bug fix for uploaded images count in achievements activity (#1885) * Versioning and changelog for v2.8.3 (#1886) * Update changelog.md * Versioning for v2.8.3
neslihanturan
pushed a commit
that referenced
this pull request
Dec 20, 2018
* Add Traceur for getting meaningful RxJava stack traces (#1832) * Hotfix for overwrite issue in 2.8.0 (#1838) * This solution is an hotfix for overrite issue came back on 2.8.0 version. What I did is checking the extension, and if it is null, adding .jpg suffix. Because commons files always have suffixes, and we should compare file names after adding suffixes. Othervise overrides are possible. * Check if file title includes an extension already, by checking if is there any dot in it. * Fix logic error * Add uncovered tests * Remove unecessary line breaks * Make Javadocs more explicit * Versioning and changelog for v2.8.2 (#1842) * Versioning for v2.8.2 * Changelog for v2.8.2 * Delete unused MaterialShowcase class * Add Javadocs and fix lint errors for DirectUpload.java * Fix whitespace and add docs * Replace fragment.getActivity() with the parentActivity var * Rename unnecessarily-overloaded method getFromWikidataQuery(), add Javadocs * Javadocs and whitespaces for NearbyPlaces.java * Use local vars where possible instead of class fields. Non-constants should not be in all caps * Missed one unnecessary class field * Remove unnecessary whitespaces that don't improve readability * Add class summary * Optimize imports * Fix access modifiers in Place.java * Clearer Javadocs * Add Javadocs to Place.java * Remove residual conflict * Fix lint issues in Sitelinks * Javadocs for Sitelinks.java * DirectUpload: Replace nested conditionals with guard clauses
maskaravivek
pushed a commit
that referenced
this pull request
Nov 27, 2019
* Add Traceur for getting meaningful RxJava stack traces (#1832) * Hotfix for overwrite issue in 2.8.0 (#1838) * This solution is an hotfix for overrite issue came back on 2.8.0 version. What I did is checking the extension, and if it is null, adding .jpg suffix. Because commons files always have suffixes, and we should compare file names after adding suffixes. Othervise overrides are possible. * Check if file title includes an extension already, by checking if is there any dot in it. * Fix logic error * Add uncovered tests * Remove unecessary line breaks * Make Javadocs more explicit * Versioning and changelog for v2.8.2 (#1842) * Versioning for v2.8.2 * Changelog for v2.8.2 * Fix data template for other source
misaochan
pushed a commit
to misaochan/apps-android-commons
that referenced
this pull request
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title (required)
Fixes #1708
Description (required)
Easier RxJava2 debugging with better stack traces.