Fix date template #3226
Merged
Fix date template #3226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This solution is an hotfix for overrite issue came back on 2.8.0 version. What I did is checking the extension, and if it is null, adding .jpg suffix. Because commons files always have suffixes, and we should compare file names after adding suffixes. Othervise overrides are possible. * Check if file title includes an extension already, by checking if is there any dot in it. * Fix logic error * Add uncovered tests * Remove unecessary line breaks * Make Javadocs more explicit
* Versioning for v2.8.2 * Changelog for v2.8.2
# Conflicts: # CHANGELOG.md # app/build.gradle # app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
|
Oh wow, there are way too many commits for this, sorry! :/ But squash merge should sort the problem out. |
maskaravivek
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
Looks good to me.
Also, @Achim55's comment is something we might want to put in our wiki. I guess most of us were not aware of the behavior. #3126 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #3126
Edited date template to format requested by Achim55, e.g. https://commons.wikimedia.org/w/index.php?title=File:Byron_lighthouse_2.jpg&diff=prev&oldid=370108941
Tests performed (required)
Tested ProdDebug on Nexus S API 27. Result: https://commons.wikimedia.org/wiki/File:Pelican_at_Main_Beach_Marina.jpg