Skip to content

When uploading several files at once the date is missing #1854 #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

When uploading several files at once the date is missing #1854 #1979

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73a3bca
bug fix #1854 wip
ashishkumar468 Nov 3, 2018
c747087
Bug fix issue #1854
ashishkumar468 Nov 4, 2018
6c9662e
fixed test cases
ashishkumar468 Nov 4, 2018
926e477
adhere to test cases
ashishkumar468 Nov 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed test cases
  • Loading branch information
@ashishkumar468
ashishkumar468 committed Nov 4, 2018
commit 6c9662efd791aee30e61932e15257ae6ba1819da
4 changes: 1 addition & 3 deletions app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionDaoTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ class ContributionDaoTest {
assertEquals("file", it.filename)
assertEquals(localUri, it.localUri.toString())
assertEquals("image", it.imageUrl)
assertEquals(created, it.timestamp.time)
assertEquals(created, it.dateCreated.time)
assertEquals(STATE_QUEUED, it.state)
assertEquals(222L, it.dataLength)
Expand All @@ -299,7 +298,6 @@ class ContributionDaoTest {
fun createFromCursor_nullableTimestamps() {
createCursor(0L, 0L, false, localUri).let { mc ->
testObject.fromCursor(mc).let {
assertNull(it.timestamp)
assertNull(it.dateCreated)
assertNull(it.dateUploaded)
}
Expand Down Expand Up @@ -342,7 +340,7 @@ class ContributionDaoTest {
source = SOURCE_CAMERA
license = "007"
multiple = isMultiple
timestamp = Date(321L)
dateCreated = Date(System.currentTimeMillis())
width = 640
height = 480 // VGA should be enough for anyone, right?
}
Expand Down