When uploading several files at once the date is missing #1854 #1979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* used absolute file path while uploading images. * updated ContributionsDao to save file creation date which previously as used to store current timestamp[the bug]. * creation notification channel before posting notification
Codecov Report
@@ Coverage Diff @@
## master #1979 +/- ##
=========================================
+ Coverage 4.37% 4.37% +<.01%
=========================================
Files 211 211
Lines 10634 10654 +20
Branches 954 956 +2
=========================================
+ Hits 465 466 +1
- Misses 10134 10152 +18
- Partials 35 36 +1
Continue to review full report at Codecov.
|
|
Hi @ashishkumar468 , I tested this on Nexus S emulator running API 27. When uploading a single image via in-app Gallery, the app crashes on image selection (from Google Photos) with this log: And uploading from camera crashes with this log: If you are modifying the upload process to this extent, you may need to do a more thorough round of tests. Generally I would test:
That being said, #1968 should be viable for release soon. Would it be better to piggyback onto that instead? You can submit your change to @maskaravivek 's branch and then you two could include it in his PR. |
|
@misaochan Piggybacking onto #1968 would be better. Also that might not require these many changes. I think fixing exif data params would just work on that, if that branch is stable and tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading several files at once the date is missing
Fixes #1854 {When uploading several files at once the date is missing}
Description (required)
While uploading images, current date was being passed as date created instead of the actual date created
Fixes #1854 {When uploading several files at once the date is missing}
Instead of copying the image in a temp file, the app would now use the absolute path of the image to upload images. Also, save the actual date created in ContributionsDao in Column "timestamp" which is currently saving uploaded date [resulting in wrong date being show in web ui]
Tests performed (required)
Tested on {29l & Google Pixel}, with {build variant, ProdDebug}.