Bug fix issue #2023 Keypad needs to be invisible in final step of upload screen#2024
Merged
misaochan merged 1 commit intocommons-app:2.9-releasefrom Nov 25, 2018
Conversation
* Explictly dismiss keyboard when user reaches the step 3(final step) of image upload
Codecov Report
@@ Coverage Diff @@
## 2.9-release #2024 +/- ##
==============================================
- Coverage 4.15% 4.15% -0.01%
==============================================
Files 223 223
Lines 11169 11171 +2
Branches 1017 1018 +1
==============================================
Hits 464 464
- Misses 10670 10672 +2
Partials 35 35
Continue to review full report at Codecov.
|
Member
|
Works well, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
While uploading an image, keyboard should automatically be dismissed when user presses next to reach the final step of the upload process
Fixes #2023, title: Keypad needs to be invisible in final step of upload screen (2.9-release branch)
What changes did you make and why?
Tests performed (required)
Tested {build variant, ProdDebug} on {One Plus 3T} with API level {27}.
Screenshots showing what changed (optional - for UI changes)
NA