Upload tests #2086
Merged
Upload tests #2086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2086 +/- ##
=========================================
+ Coverage 4.02% 5.61% +1.59%
=========================================
Files 226 225 -1
Lines 11467 11371 -96
Branches 1064 1063 -1
=========================================
+ Hits 461 638 +177
+ Misses 10972 10681 -291
- Partials 34 52 +18
Continue to review full report at Codecov.
|
2a01b5e to
d97cc37
Compare
misaochan
reviewed
Dec 10, 2018
| class GPSExtractorTest { | ||
|
|
||
| @Test | ||
| fun getCoords() { |
There was a problem hiding this comment.
Should these empty tests be removed?
|
Looks good to me. Happy to merge after the empty tests for GPSExtractor are cleaned up. :) |
|
@misaochan Have just updated the PR addressing the comment. |
|
Thanks @maskaravivek ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes Part of #705
What changes did you make and why?
Added unit tests.
Have added test cases for whatever code flows could be tested with no or minor refactoring. Haven't taken up major refactoring to accommodate more test cases.
FileProcessorcannot be tested currently as it creates instances ofGPSExtractorandFilewhich makes it impossible to mock.GPSExtractoragain cannot be tested as it is creating instances ofExifInterfaceTests performed (required)
Tests pass. If both the checks for this PR pass, then it can be merged to master. No functionality has been changed.