-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix night mode accent color #2098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2098 +/- ##
=========================================
+ Coverage 5.61% 5.77% +0.16%
=========================================
Files 225 231 +6
Lines 11371 11604 +233
Branches 1063 1079 +16
=========================================
+ Hits 638 670 +32
- Misses 10681 10878 +197
- Partials 52 56 +4
Continue to review full report at Codecov.
|
Fixes #2187 |
As feedback for next time @Ojonathan I'd recommend developing on a different branch just so it's easier to keep your own master updated and makes it easier for reviewers to load. |
Test results Automated tests pass Tested Screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge once Travis finished
…erLightColor
Fixing color for night mode, suggestion of primarySuperLightColor.
Fixes #2071 New upload UI not compatible with night mode
What changes did you make and why?
Change LightTheme Style for layout_upload_categories.xml
Tested on emulator with API level 27