Skip to content

Fix night mode accent color #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Fix night mode accent color #2098

merged 2 commits into from
Dec 20, 2018

Conversation

Ojonathan
Copy link
Contributor

…erLightColor

Fixing color for night mode, suggestion of primarySuperLightColor.

Fixes #2071 New upload UI not compatible with night mode

What changes did you make and why?
Change LightTheme Style for layout_upload_categories.xml

Tested on emulator with API level 27

screenshot_1544478340

@codecov-io
Copy link

codecov-io commented Dec 10, 2018

Codecov Report

Merging #2098 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2098      +/-   ##
=========================================
+ Coverage    5.61%   5.77%   +0.16%     
=========================================
  Files         225     231       +6     
  Lines       11371   11604     +233     
  Branches     1063    1079      +16     
=========================================
+ Hits          638     670      +32     
- Misses      10681   10878     +197     
- Partials       52      56       +4
Impacted Files Coverage Δ
...a/fr/free/nrw/commons/utils/ContributionUtils.java 6.77% <0%> (-5.35%) ⬇️
...n/java/fr/free/nrw/commons/CommonsApplication.java 41.77% <0%> (-2.81%) ⬇️
...n/java/fr/free/nrw/commons/auth/LoginActivity.java 0% <0%> (ø) ⬆️
...ee/nrw/commons/media/MediaDetailPagerFragment.java 0% <0%> (ø) ⬆️
.../nrw/commons/nearby/NearbyNoificationCardView.java 0% <0%> (ø) ⬆️
...java/fr/free/nrw/commons/nearby/PlaceRenderer.java 0% <0%> (ø) ⬆️
...a/fr/free/nrw/commons/nearby/NearbyController.java 0% <0%> (ø) ⬆️
.../java/fr/free/nrw/commons/nearby/NearbyPlaces.java 0% <0%> (ø) ⬆️
...ain/java/fr/free/nrw/commons/nearby/Sitelinks.java 0% <0%> (ø) ⬆️
...w/commons/category/CategoryImagesListFragment.java 0% <0%> (ø) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a90c0...d136874. Read the comment docs.

@domdomegg
Copy link
Member

Fixes #2187

@domdomegg
Copy link
Member

As feedback for next time @Ojonathan I'd recommend developing on a different branch just so it's easier to keep your own master updated and makes it easier for reviewers to load.

@domdomegg
Copy link
Member

Test results

Automated tests pass

Tested 2.8.5-debug-master~d1368742 on Galaxy Nexus (emulator) at API level 28
Uploaded file to beta commons: https://commons.wikimedia.beta.wmflabs.org/wiki/File:Test2098.jpg

Screenshots

screenshot_1545327946
screenshot_1545327948
screenshot_1545327964
screenshot_1545327974
screenshot_1545328000
screenshot_1545328003
screenshot_1545328009

Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once Travis finished

@domdomegg domdomegg changed the title Replacement of color "primaryColor" for the light theme by primarySup… Fix night mode accent color Dec 20, 2018
@domdomegg domdomegg merged commit f521e88 into commons-app:master Dec 20, 2018
This was referenced Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants