Skip to content

Changed toggle switches and text color in night mode in settings(#2187) #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cypherop
Copy link
Contributor

Fixes #2187 Night mode:settings

What changes did you make and why?
Changed color for colorAccent attribute

Tested on Motorola Moto G5 plus with API level 24

@codecov-io
Copy link

Codecov Report

Merging #2195 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2195   +/-   ##
======================================
  Coverage    5.77%   5.77%           
======================================
  Files         231     231           
  Lines       11599   11599           
  Branches     1078    1078           
======================================
  Hits          670     670           
  Misses      10873   10873           
  Partials       56      56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec1e51...dd653b6. Read the comment docs.

@domdomegg domdomegg self-requested a review December 20, 2018 16:47
Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure about the color you've chosen - it's pretty different from the rest of the app theme. I had a more boring color in mind e.g. light grey. Alternatively if we do want a bit of colour maybe use a pale blue color?

Given this is now the new night theme accent color, could we call it that in colors.xml? Especially as it also has affect elsewhere e.g. tabs, subtitles e.g. rename toggle_switches_color to accent_color_dark

Tested 2.9.0-debug-pr-2195~dd653b6a on Galaxy Nexus (emulator) at API level 28

screenshot_1545324666

@domdomegg
Copy link
Member

Also I noticed on the about page it seems like some links aren't being coloured with the correct accent color. In the sceeenshot below, notice "Github issue" is the accent color but "Rate us" is blue link color.

Depending on what the fix is it might be better to submit a different PR but maybe you could have a look into standardising that?

screenshot_1545324892

@domdomegg
Copy link
Member

I was just reviewing #2098 and it looks like that PR fixes it. As it's ready to merge and was submitted earlier I'm going to close this in favor of #2098.

Apologies for advising on doing the issue

@domdomegg domdomegg closed this Dec 20, 2018
@cypherop cypherop deleted the fix#2187 branch December 20, 2018 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants