Skip to content

Conversation

@cypherop
Copy link
Contributor

Fixes #2136 SearchActivity tab names are hardcoded

SearchActivity has the tab names ("MEDIA" and "CATEGORIES") hardcoded.I defined these names into strings.xml file.

@commons-app commons-app deleted a comment from codecov-io Dec 17, 2018
@domdomegg
Copy link
Member

Don't feel names explain correctly what these strings represent. You're not really searching for media by category, more like searching for categories?

Maybe something like search_tab_title_media and search_tab_title_categories?

@cypherop
Copy link
Contributor Author

done

@domdomegg
Copy link
Member

Rebasing to fix Travis issues so it provides accurate result before merge...

@codecov-io
Copy link

Codecov Report

Merging #2137 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2137   +/-   ##
======================================
  Coverage    5.53%   5.53%           
======================================
  Files         233     233           
  Lines       11586   11586           
  Branches     1078    1078           
======================================
  Hits          641     641           
  Misses      10892   10892           
  Partials       53      53
Impacted Files Coverage Δ
...va/fr/free/nrw/commons/explore/SearchActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f497217...baa5dfd. Read the comment docs.

@domdomegg domdomegg merged commit 11e5c3c into commons-app:master Dec 17, 2018
@cypherop cypherop deleted the fix#2136 branch December 20, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants