Bring back the label for multiple upload intent #2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the upload revamp, commit f607c1c (Multiple uploads with over haul (commons-app#1968), 19 Nov 2018), kept back the label for the single upload intent but removed the label for the multiple upload intent. Correct it and bring back the label for the multiple upload intent thus giving a more useful label for the intent, again.
Contributor
|
@sivaraam Can you link the PR to the relevant issue. If an issue doesn't exist please create one. :) |
Member
Author
|
Done. |
maskaravivek
approved these changes
Dec 25, 2018
Contributor
|
Thanks @sivaraam :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #2229
In the upload revamp, commit f607c1c (Multiple uploads with over haul (#1968), 19 Nov 2018),
kept back the label for the single upload intent but removed the label for the multiple upload
intent.
Correct it and bring back the label for the multiple upload intent thus giving a more useful
label for the intent, again.
Tests performed (required)
Not tested but shouldn't have any issues as this was based on my previous commit 783b695 (which was in PR #1680).
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.