Skip to content

Handle null URI while uploading picture #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2019

Conversation

maskaravivek
Copy link
Member

Description (required)

Fixes #2033

What changes did you make and why?

Have started handling null URI from the received intent. It should fix the issue @misaochan was facing. There can be other reasons for app getting stuck at this step. We can keep an eye on the reports and fix those issues as well.

@codecov-io
Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #2262 into master will increase coverage by <.01%.
The diff coverage is 29.41%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2262      +/-   ##
=========================================
+ Coverage    6.35%   6.36%   +<.01%     
=========================================
  Files         233     233              
  Lines       11570   11585      +15     
  Branches     1065    1069       +4     
=========================================
+ Hits          735     737       +2     
- Misses      10773   10785      +12     
- Partials       62      63       +1
Impacted Files Coverage Δ
...a/fr/free/nrw/commons/upload/FileUtilsWrapper.java 42.85% <0%> (+5.35%) ⬆️
...ain/java/fr/free/nrw/commons/upload/FileUtils.java 10.41% <0%> (-0.28%) ⬇️
...ava/fr/free/nrw/commons/upload/UploadActivity.java 0% <0%> (ø) ⬆️
...n/java/fr/free/nrw/commons/upload/UploadModel.java 60.09% <66.66%> (+0.38%) ⬆️
...in/java/fr/free/nrw/commons/utils/StringUtils.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a48a09a...1917296. Read the comment docs.

@misaochan misaochan merged commit e773a82 into commons-app:master Jan 4, 2019
misaochan added a commit that referenced this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App stuck at "receiving shared content"
3 participants