-
Notifications
You must be signed in to change notification settings - Fork 1.3k
App stuck at "receiving shared content" #2033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I faced this issue, too. Specifically, I saw it the first time I tried to upload in v2.9.0. I thought it would never finish but it did after about 30 seconds. That's a long time and might make first time users of the app think it's not useful at all. So, I guess it would be nice to explore the issue and fix it. Also, I guess the message could be displayed more prominently in the center rather than at the bottom as there is a lot of space. It was very tiny regardless of the lot of space available to display it. |
Ah, thanks for reporting @sivaraam ! I added it to our list of hotfixes. I do agree that it shouldn't be taking that long, especially when we're not even uploading the picture yet at that stage. If you could Send Logs the next time it happens for you, that would be fantastic. :) |
I tried to reproduce this. I guess I'm getting a long delay for new images that I try to upload. I'm not sure but it seems like that to me. Unfortunately I don't have a log that captures one specific upload that took a long time. It might be cluttered with other ones too (that may/may not have taken a long time). I will share if I could capture a log specifically. Let me know if you're ok with the cluttered one too. BTW, I see that the app crashes when trying to upload images of bigger sizes (>=4MB). I'm not sure why. I've submitted a bug report for the crash. This is too odd and I guess it should be fixed before the v2.9 leaves beta. |
@sivaraam Does the app consistently crash for you for images >=4MB |
Hi @sivaraam , could you use Send Logs to send us the logs immediately after a crash please? The crash reporting system unfortunately needs some work. :/ |
The app does crash consistently but the case the scenario is a little different. Actually, I stated that the app crashed when I tried to upload images greater than 4MB because it crashed repeatedly when I tried to upload two images whose sizes were around 4MB and 14MB. Those images were to downloaded from commons. I also tried to download images from the web and tried to see when the app crashed. It consistently crashes when try to upload an image whose size is greater than 2MB. Note that it crashes in the "Receiving shared content" page itself. I never see the 3 steps page. You could find the images for which I consistently see the app crash in the following link:
Ok. I've sent the email. I guess I should attach the file present within the 'logs/prod' folder in my device's 'Download' directory. Tapping on 'Send logs' just filled in the email address, subject, message body. No files were attached. So, I just wanted to be sure. |
Strange, normally it is a zip file and it is always automatically attached to the email for me. @maskaravivek any idea why he's only getting one of the files? |
FWIW, I use K-9 mail as my email client. |
BTW, I've forgot to mention that there were several files in the |
I just had this issue (progress bar loading forever, not the crash) happen to me again. It seems that it happens after a permission request and approval (API 26 Samsung Galaxy S7). The upload screen literally NEVER loads, I left it on for 2 min. Logs below.
|
I just had this happen on 2.9.0.114 it is still spinning after 30 minutes. |
Was it a bulk upload @nicolas-raoul ? Or one by one? |
Yes, the 16 pictures that got stuck were as a bulk upload. |
Got this ("receiving" taking forever) problem again yesterday and today, each time for a single small smartphone picture. |
Each time, I just try again and the picture uploads correctly with that same "receiving" screen taking only like two seconds. |
@nicolas-raoul Does it happen just after granting storage permissions or does it happen randomly? I haven't been able to find a pattern to reproduce the above issue. "Receiving shared intent" shows up during the preprocessing of the image, so I was hoping that making this flow more robust would reduce the occurrence of this issue. In this regard, I was working on fixing #2083. |
It happens randomly: An upload works, and the next fails, despite using the
same method (sharing from Android stock gallery).
…On Mon, Dec 24, 2018, 01:03 Vivek Maskara ***@***.*** wrote:
@nicolas-raoul <https://github.com/nicolas-raoul> Does it happen just
after granting storage permissions or does it happen randomly?
I haven't been able to find a pattern to reproduce the above issue.
"Receiving shared intent" shows up during the preprocessing of the image,
so I was hoping that making this flow more robust would reduce the
occurrence of this issue. In this regard, I was working on fixing #2083
<#2083>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2033 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGFBr2E6BrM8BPWRIOSL__nlxqWHlANks5u79qWgaJpZM4Yy24r>
.
|
@maskaravivek I wonder what exactly goes on during the preprocessing stage? This was never an issue before the upload flow overhaul, and AFAIK we have not actually added any sort of file processing that wasn't there before. Should we try fixing the file URI NPE that I posted in my comment above and see if that helps? |
@ALL The PR #2262 is supposed to fix the null URI issue that @misaochan was facing. I will take a look at the image shared by @sivaraam to see if it is reproducible for me. |
To address this, am changing the waiting text to. Please suggest if it can be changed to something more meaningful.
|
Whoops, I should have tried to reproduce the error before merging this. @maskaravivek , #2262 seems to have made things worse. Now, once I get the error, I get the "error when processing image" toast, which is OK... but now NO future uploads ever succeed for me. Every single subsequent image I try to upload gets the error, I tried both the same image and other images. Previously, at least after the first time, I could upload subsequent images. It does not adversely affect you until you hit the error, but it is still a release blocker. Was running on my real device so could not get logs via adb, but I sent logs from misaochan2 through the Send Log File method. |
Ah, I managed to reproduce this on my emulator finally. I found that this issue only happens to me via Nearby direct uploads. Uploading the exact same file via the "Gallery" in-app button succeeds. This happens for both emulator and real device.
On a side note, there appears to be an issue with Send Logs (at least, when running a debug build). On my real device I don't seem to be able to get any meaningful logs today. See my submitted logs in the google groups forum - I have actually done a lot with the Commons app on my real device today (4 Jan), but there are almost no logs generated. |
Reposting my observations that I told Vivek about (so that anyone else looking at the issue can be updated). If you are experiencing the issue too, feel free to post your own observations, and see if they are similar to mine.
|
I've not tested with the change that has been merged but when I observed this issue initially I did not do any nearby uploads. I guess it was either a upload initiated from the app or an upload initiated by sharing from the gallery. |
@sivaraam Regarding the crash that you were experiencing, I managed to upload all 4 images successfully on the beta server without any crashes. I used Redmi Note 5 for testing. Can you verify if the latest master build work for you?
@misaochan Am looking at the issue and am trying to figure out why the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks I'll look into it and share the results. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yes, you need to both join the Google Group AND sign up at the Google Play test page to get the alpha. The Google Play test page is the same for both alpha and beta, but being a member of the Google Group is what differentiates your account. Personally I wish there was a clearer way, this way is kinda confusing to users, but we have no say in this. |
OK. I thought I joined the group yesterday seems I wasn't careful enough to verify it, sorry. How long does it take to receive the alpha update? Or would I get an update only for the next alpha release? Anyways, I managed to build the app from source yesterday. When I try to upload the images I shared I could cause the processing stage for only one of it. Interestingly this time it doesn't seem to be dependent on size as I'm able to cross the preprocessing stage for the image with the largest size. That's sppoky, isn't it? I've sent the crash reports via e-mail for the images that resulted in a crash. I've also attached the images with them. I use a low-end phone (1GB RAM, 8GB Internal storage; Samsung SM-J111F). Is that somehow the reason the app crashes for me but not for you @maskaravivek? Also, does the processing stage require a reliable network connection? I hope not but just wanted to know as the network is a little wavery here and not very reliable. |
You should be able to receive the alpha update within a couple of hours. However, I'm not sure if the About page will reflect the correct version number (see #2127 ). The ACRA crash report should have the correct version number though. Thanks for the crash reports! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@nicolas-raoul We have just pushed a fix for this issue. It should no longer happen. |
@maskaravivek I think @nicolas-raoul asked me about the updated the updated wiki page when he stated:
Or have I misunderstood it? 🤔 |
Sorry, my comment wasn't in reply to the wiki issue. It was about the fix to the bug. Let me hide unrelated comments to avoid confusion. :) |
@maskaravivek Thanks! I have uploaded many pictures recently and I have not gotten this error, whereas I was getting it very often before your commit :-) |
In case you refer to the fix in #2278 which seems to available in the alpha version v2.9.0.163 if I'm right. I tried using that version to see if I could upload the images for which I was experiencing a crash previously. Sadly, the app still crashes for me when I try to upload them :-( It crashed in the processing stage itself (just as in #2033 (comment)). I've sent the crash reports this time too. |
@sivaraam Thanks for sharing the logs. The issue you are facing is related to #2083. This issue was related to the Out of memory (OOM) crash that you are facing is because of large images not being handled properly. Let's take the discussion about this crash to #2083. :) |
This issue is permanently there in the latest master. Not even a single image could be uploaded until I went some commits back. Will have to check which commit caused the problem. |
@ShridharGoel My last commit caused this issue. The PR fixing it is up for review. #2309. |
This issue happens:
|
Yes, @misaochan also reported this issue. Am working on fixing it. :)
Thanks. Also, am making changes to switch to |
I haven't seen this for a while. If that happens again please tell us, thanks! :-) |
Summary:
Occasionally, after selecting an image to upload in 2.9-release, I get stuck at the "Receiving shared content" page. I can't find any pattern to when it happens (probably 1 in 10 uploads), and retrying with the same image usually works.
System logs:
Device and Android version:
Samsung Galaxy s7 API 26
Commons app version:
2.9-release prodRelease
Would you like to work on the issue?
Pref not
The text was updated successfully, but these errors were encountered: