Skip to content

Added Delete specific search feature(#2241) #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

cypherop
Copy link
Contributor

@cypherop cypherop commented Jan 5, 2019

Fixes #2241 Delete specific search

What changes did you make and why?
Used OnItemLongClickListener to delete specific search .On long click a dialog box appears asking the user if he wants to delete this search

Tested on Motorola Moto G5 plus with API level 24.

@codecov-io
Copy link

codecov-io commented Jan 5, 2019

Codecov Report

Merging #2275 into master will decrease coverage by 3.58%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2275      +/-   ##
=========================================
- Coverage    6.28%   2.69%   -3.59%     
=========================================
  Files         233     258      +25     
  Lines       11600   12312     +712     
  Branches     1069    1114      +45     
=========================================
- Hits          729     332     -397     
- Misses      10810   11954    +1144     
+ Partials       61      26      -35
Impacted Files Coverage Δ
...mons/explore/recentsearches/RecentSearchesDao.java 0% <0%> (ø) ⬆️
...explore/recentsearches/RecentSearchesFragment.java 0% <0%> (ø) ⬆️
...r/free/nrw/commons/utils/model/ConnectionType.java 0% <0%> (-100%) ⬇️
.../fr/free/nrw/commons/logging/CommonsLogSender.java 0% <0%> (-93.11%) ⬇️
.../java/fr/free/nrw/commons/di/NetworkingModule.java 0% <0%> (-90%) ⬇️
...e/nrw/commons/di/CommonsDaggerContentProvider.java 0% <0%> (-80%) ⬇️
...java/fr/free/nrw/commons/utils/DeviceInfoUtil.java 0% <0%> (-75%) ⬇️
.../free/nrw/commons/di/ApplicationlessInjection.java 0% <0%> (-73.69%) ⬇️
...nrw/commons/di/CommonsDaggerAppCompatActivity.java 0% <0%> (-72.73%) ⬇️
...n/java/fr/free/nrw/commons/theme/BaseActivity.java 0% <0%> (-66.67%) ⬇️
... and 147 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabcd43...2d8999b. Read the comment docs.

Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 2.9.0-debug-fix#2241~2d8999bca

@domdomegg
Copy link
Member

Sorry about the long wait for a review. Looks great to me, will merge once Travis build is finished.

@domdomegg domdomegg merged commit cbf625d into commons-app:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants