Make uploading file notification quieter on some devices(Fixed #2528) #2529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-app#2528) Add setOnlyAlertOnce flag to NotificationCompat.Builder. This fixed the issue that notification makes an alarm(beep) every time uploading progress updated on some devices. Also let UploadService.class reuse NotificationCompat.Builder as much as possible(instead of creating a NotificationCompat.Builder every time in method uploadContribution). And some small refactors.
Codecov Report
@@ Coverage Diff @@
## master #2529 +/- ##
=========================================
- Coverage 5.9% 5.9% -0.01%
=========================================
Files 258 258
Lines 12304 12305 +1
Branches 1103 1103
=========================================
Hits 726 726
- Misses 11519 11520 +1
Partials 59 59
Continue to review full report at Codecov.
|
|
Never experienced this issue on my device, but looks good to me. Merging so we can get alpha users' feedback. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #2528
Add setOnlyAlertOnce flag to NotificationCompat.Builder. This fixed
the issue that notification makes an alarm(beep) every time uploading
progress updated on some devices.
Also let UploadService.class reuse NotificationCompat.Builder as much
as possible(instead of creating a NotificationCompat.Builder every
time in method uploadContribution). And some small refactors.
Tests performed (required)
Tested master betaDebug on Nexus 6P with API level 27.