Notification makes an alarm(beep) every time when uploading / DeleteTask progress updated #2528
Comments
|
I have never noticed that, but I remember someone talking about it. |
…s-app#2528) Add setOnlyAlertOnce flag to NotificationCompat.Builder. This fixed the issue that notification makes an alarm(beep) every time uploading progress updated on some devices. Also let UploadService.class reuse NotificationCompat.Builder as much as possible(instead of creating a NotificationCompat.Builder every time in method uploadContribution). And some small refactors.
…#2529) Add setOnlyAlertOnce flag to NotificationCompat.Builder. This fixed the issue that notification makes an alarm(beep) every time uploading progress updated on some devices. Also let UploadService.class reuse NotificationCompat.Builder as much as possible(instead of creating a NotificationCompat.Builder every time in method uploadContribution). And some small refactors.
…p#2528) As commit ab4fca5 does, this commit fixed the repeated notification alarms in DeleteTask.class. Since progress indication in notification can be cleared by calling .setProgress(0,0,false) on notificationBuilder(As shown in DeleteTask.class). This commit also refactored notification related code in UploadService.class. Make progress and failed notification uses the same notificationBuilder.
) As commit ab4fca5 does, this commit fixed the repeated notification alarms in DeleteTask.class. Since progress indication in notification can be cleared by calling .setProgress(0,0,false) on notificationBuilder(As shown in DeleteTask.class). This commit also refactored notification related code in UploadService.class. Make progress and failed notification uses the same notificationBuilder.
|
Still happens, on current master with API 26 emultor |
|
The previous fix used setOnlyAlertOnce to let the notification only alert once. It fixed the repeating alert on some devices with API level 27/28. I searched "setOnlyAlertOnce api 26" on the web and didn't find any interesting results. Unfortunately I don't have the environment to test this issue on API 26 emulator. Hope above information can help to resolve this issue on API 26 emulator. |
|
Thanks @zhao-gang it was helpful! |
|
Hi @neslihanturan , I'm new to contributing to OSS and I'd like to help with fixing this issue. However, I tried this on the current master branch and API 25 emulator, but it seems I'm unable to repro it while uploading the file (not yet tested on deletion); there's no notification sound for me. Perhaps I'm doing something wrong, but may I know the current status of this issue? |
|
@andrew-tc Could you please try with API 26 emulator? |
|
@pigsonthewing reports an audio alert notification that an upload has started, on a OnePlus Nord, running OxygenOS, v. 10.5.10.AC018A - https://en.wikipedia.org/wiki/OxygenOS |
Summary:
When uploading a file, notification makes a sound every time the uploading progress updated. Which is very annoying.
System logs:
The current notification also generate some system error logs like:
Device and Android version:
Nexus 6P(with Android Oreo) and Pixel 2 XL(with Android Pie) have above issue.
Commons app version:
master betaDebug
Would you like to work on the issue?
Yes
The text was updated successfully, but these errors were encountered: