Make DeleteTask notification quieter on some devices(Fixed #2528) #2538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p#2528) As commit ab4fca5 does, this commit fixed the repeated notification alarms in DeleteTask.class. Since progress indication in notification can be cleared by calling .setProgress(0,0,false) on notificationBuilder(As shown in DeleteTask.class). This commit also refactored notification related code in UploadService.class. Make progress and failed notification uses the same notificationBuilder.
Codecov Report
@@ Coverage Diff @@
## master #2538 +/- ##
=========================================
+ Coverage 5.89% 5.9% +<.01%
=========================================
Files 258 258
Lines 12306 12305 -1
Branches 1103 1103
=========================================
Hits 726 726
+ Misses 11521 11520 -1
Partials 59 59
Continue to review full report at Codecov.
|
|
Thanks @zhao-gang ! It works as intended, great job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
This is a followup fix of issue #2528
What changes did you make and why?
As commit ab4fca5 does, this commit fixed the repeated notification
alarms in DeleteTask.class.
Since progress indication in notification can be cleared by calling
.setProgress(0,0,false) on notificationBuilder(As shown in DeleteTask.class).
This commit also refactored notification related code in UploadService.class.
Make progress and failed notification uses the same notificationBuilder.
Tests performed (required)
Tested master betaDebug on Nexus 6P with API level 27.