Skip to content

Use Timber.e(Throwable t, String message, Object... args) #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Use Timber.e(Throwable t, String message, Object... args) #2582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public void fetch(String filename, LicenseList licenseList) throws IOException {
Timber.d("Nominated for deletion: " + deletionStatus);
}
catch (Exception e){
Timber.d(e.getMessage());
Timber.d(e, "Exception during fetching");
}

MediaResult result = mediaWikiApi.fetchMediaByFilename(filename);
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/fr/free/nrw/commons/campaigns/CampaignsPresenter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public void getCampaigns() {
}

@Override public void onError(Throwable e) {
Timber.e(e.getMessage(), "could not fetch campaigns");
Timber.e(e, "could not fetch campaigns");
}
});
}
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/fr/free/nrw/commons/contributions/ContributionDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ private static void runQuery(SQLiteDatabase db, String query) {
try {
db.execSQL(query);
} catch (SQLiteException e) {
Timber.e("Exception performing query: " + query + " message: " + e.getMessage());
Timber.e(e, "Exception performing query: " + query);
}
}

Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/fr/free/nrw/commons/nearby/NearbyPlaces.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ List<Place> radiusExpander(LatLng curLatLng, String lang, boolean returnClosestR
try {
places = getFromWikidataQuery(curLatLng, lang, radius);
} catch (InterruptedIOException e) {
Timber.e(e,"exception in fetching nearby places");
Timber.e(e, "exception in fetching nearby places");
return places;
}
Timber.d("%d results at radius: %f", places.size(), radius);
Expand Down