Skip to content

[WIP] Remove unused resources #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

maskaravivek
Copy link
Member

Checking if Android's "remove unused resources" is actually effective or does it remove resources that are currently being used.

@maskaravivek
Copy link
Member Author

@domdomegg @whym Have you used Android Studio's "Remove unused resources" before? I am skeptical that it might remove resources that are currently being used(esp for resources that are not in values/strings.xml ie it might think values-mg/strings.xml is not used).

@maskaravivek maskaravivek marked this pull request as ready for review March 20, 2019 14:28
@maskaravivek maskaravivek changed the title Remove unused resources [WIP] Remove unused resources Mar 20, 2019
@maskaravivek
Copy link
Member Author

Note: It is just a test PR. Marked it as "ready for review" as Travis build wasn't kicking in without it. :/

@domdomegg
Copy link
Member

I've never used "Remove unused resources". From the surface it looks like this has worked (given Travis builds). I'd be happy to merge this after extensive testing (I could do this evening if you'd be okay with me merging it).

@domdomegg
Copy link
Member

The one annoying thing it's done is weirdly indented some of the .xml files, which is the cause of the additions.

@maskaravivek
Copy link
Member Author

I've never used "Remove unused resources". From the surface it looks like this has worked (given Travis builds). I'd be happy to merge this after extensive testing (I could do this evening if you'd be okay with me merging it).

Yup, even if I am testing on my end. Will test in 2 languages to see if things work.

@domdomegg domdomegg self-requested a review March 20, 2019 19:30
@domdomegg
Copy link
Member

Bug: navigation drawer missing dividing sections:

master 2685
Screenshot_1553110711 Screenshot_1553110704

@domdomegg
Copy link
Member

Bug: nice license names lost

master 2685
Screenshot_1553110953 Screenshot_1553110978

@maskaravivek
Copy link
Member Author

Since it breaks a few things, i am closing the PR.

@domdomegg domdomegg removed their request for review March 21, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants