Skip to content

Removed unused strings from strings.xml #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

vanshikaarora
Copy link
Contributor

REmoved strings with no default values from strings.xml

Fixes #2655 Fix warnings about string resources 'without required default value'

Changes made

Removed various strings from:

  • values-ab/strings.xml
  • values-af/strings.xml
  • values-ar/strings.xml
  • values-ast/strings.xml

@maskaravivek
Copy link
Member

maskaravivek commented Mar 20, 2019

@vanshikaarora How did you do it? Did you manually delete the strings? I was wondering if there would be a easier way

@vanshikaarora
Copy link
Contributor Author

vanshikaarora commented Mar 20, 2019

@maskaravivek I wasn't able to reproduce this error.
Also, since the number of strings were less, I have deleted them manually.

I was wondering if there would be a easier way

Do you have some other suggestion?

@maskaravivek
Copy link
Member

Trying out an alternative in #2685. Let's see if build succeeds.

@domdomegg domdomegg self-requested a review March 21, 2019 18:12
Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 2.10.1-debug-string_default_value~0f06b5e3a

@codecov-io
Copy link

Codecov Report

Merging #2684 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2684      +/-   ##
=========================================
- Coverage    2.81%   2.61%   -0.21%     
=========================================
  Files         258     268      +10     
  Lines       12376   13369     +993     
  Branches     1111    1276     +165     
=========================================
  Hits          349     349              
- Misses      12001   12994     +993     
  Partials       26      26
Impacted Files Coverage Δ
...n/java/fr/free/nrw/commons/MediaDataExtractor.java 0% <0%> (ø) ⬆️
...free/nrw/commons/theme/NavigationBaseActivity.java 0% <0%> (ø) ⬆️
...rw/commons/mwapi/ApacheHttpClientMediaWikiApi.java 0% <0%> (ø) ⬆️
...java/fr/free/nrw/commons/upload/UploadService.java 0% <0%> (ø) ⬆️
...fr/free/nrw/commons/media/MediaDetailFragment.java 0% <0%> (ø) ⬆️
.../fr/free/nrw/commons/di/ActivityBuilderModule.java 0% <0%> (ø) ⬆️
...in/java/fr/free/nrw/commons/delete/DeleteTask.java 0% <0%> (ø) ⬆️
.../fr/free/nrw/commons/di/FragmentBuilderModule.java 0% <0%> (ø) ⬆️
...r/free/nrw/commons/review/ReviewImageFragment.java 0% <0%> (ø)
...free/nrw/commons/utils/MediaDataExtractorUtil.java 0% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72bd44...0f06b5e. Read the comment docs.

@domdomegg domdomegg merged commit 711a1db into commons-app:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants