Skip to content

Refactor asynctasks to Rxjava implementation #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Refactor asynctasks to Rxjava implementation #2707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/src/main/java/fr/free/nrw/commons/di/ActivityBuilderModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ public abstract class ActivityBuilderModule {
@ContributesAndroidInjector
abstract BookmarksActivity bindBookmarksActivity();


@ContributesAndroidInjector
abstract ReviewActivity bindReviewActivity();
}
10 changes: 3 additions & 7 deletions app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,9 @@
import fr.free.nrw.commons.contributions.ContributionsSyncAdapter;
import fr.free.nrw.commons.delete.DeleteTask;
import fr.free.nrw.commons.modifications.ModificationsSyncAdapter;
import fr.free.nrw.commons.review.CheckCategoryTask;
import fr.free.nrw.commons.review.SendThankTask;
import fr.free.nrw.commons.review.ReviewController;
import fr.free.nrw.commons.settings.SettingsFragment;
import fr.free.nrw.commons.nearby.PlaceRenderer;
import fr.free.nrw.commons.settings.SettingsFragment;
import fr.free.nrw.commons.upload.FileProcessor;
import fr.free.nrw.commons.widget.PicOfDayAppWidget;

Expand Down Expand Up @@ -45,12 +43,10 @@ public interface CommonsApplicationComponent extends AndroidInjector<Application

void inject(DeleteTask deleteTask);

void inject(CheckCategoryTask checkCategoryTask);

void inject(SendThankTask sendThankTask);

void inject(SettingsFragment fragment);

void inject(ReviewController reviewController);

@Override
void inject(ApplicationlessInjection instance);

Expand Down
129 changes: 0 additions & 129 deletions app/src/main/java/fr/free/nrw/commons/review/CheckCategoryTask.java
View file
Open in desktop

This file was deleted.

Loading