Fix#2761: Loading of different image on Peer Review on rotation

[cypherop]

Description (required)

Fixes #2761

Tests performed (required)

Tested ProdDebug on Motorola Moto G5 plus with API level 24.

[neslihanturan]

Thanks but this method is not suggested if it is not the only option. The solution with this method https://developer.android.com/guide/topics/resources/runtime-changes#RetainingAnObject is what we need

[codecov-io]

Codecov Report

Merging #2762 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2762      +/-   ##
=========================================
- Coverage    2.83%   2.83%   -0.01%     
=========================================
  Files         268     268              
  Lines       12774   12782       +8     
  Branches     1129    1131       +2     
=========================================
  Hits          362     362              
- Misses      12387   12395       +8     
  Partials       25      25

Impacted Files	Coverage Δ
...ava/fr/free/nrw/commons/review/ReviewActivity.java	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14a9c1...44fb80c. Read the comment docs.

[cypherop]

@neslihanturan So should I create a new ViewModel class and use it for retaining views?

[neslihanturan]

No it is for carrying large objects. You should use onSaveInstanceState()

[cypherop]

@neslihanturan I have done the changes and have updated the PR.

[neslihanturan]

Code seems alright, will merge after tested:)

[neslihanturan]

This passes from my tests but there is a point I recognized, and want to wait for review from another person too. Since

    @SuppressLint("CheckResult")
    private void updateImage(String fileName) {
...
        this.fileName = fileName;
...
        reviewPager.setCurrentItem(0);

how we don't start from the first question each time?

[neslihanturan]

Hi @Sp2710 , closing this one since the Review Activity implementation is changed since then and a suitable solution is available. Thanks for your contribution.