Avoid jargon and slang, change for default, de and pl (#2874)

[marcin-kwasniak]

"check category failure title" and "check category success title" shouldn't use the words "success" and "failure"

Fixes #{#2874} for default, de and pl

[misaochan]

I don't think we should be editing the non-default language strings directly, everything except default will be overriden by translatewiki's automatic updates AFAIK.

For the default, I'll leave a comment on the code itself.

[marcin-kwasniak]

Ok, so i close this pull request.

[misaochan]

@marcin-kwasniak , you can make changes within the PR itself. If you modify your code, commit it to the same branch and push the branch, we will automatically get your changes.

[codecov-io]

Codecov Report

Merging #2876 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2876      +/-   ##
=========================================
- Coverage    3.42%   3.42%   -0.01%     
=========================================
  Files         246     246              
  Lines       12193   12208      +15     
  Branches     1071    1072       +1     
=========================================
  Hits          418     418              
- Misses      11744   11759      +15     
  Partials       31      31

Impacted Files	Coverage Δ
...fr/free/nrw/commons/settings/SettingsFragment.java	0% <0%> (ø)	⬆️
.../fr/free/nrw/commons/widget/PicOfDayAppWidget.java	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bde4f9...c871413. Read the comment docs.

[marcin-kwasniak]

@misaochan I made change, is it ok now?

[misaochan]

Hi @marcin-kwasniak ,

My suggestion was to have "Category check successfully requested" for the success string, because "category check requested" does not necessarily mean success IMO. Your text for the failure string was fine, there was no need to remove it.

[marcin-kwasniak]

My mistake, new text for fail is commited.

[misaochan]

Thanks, and congrats on your first PR! :)