"check category failure title" and "check category success title" shouldn't use the words "success" and "failure" #2874

amire80 · 2019-04-10T09:27:00Z

These two messages say:

Requesting category check: Success
Requesting category check: Failed

Using the words "Success" and "Failed" in user interface messages is a bad practice. See the explanation here: https://www.mediawiki.org/wiki/Localisation#Avoid_jargon_and_slang .

They should be rephrased in a more human way. For example:

Category check requested
Category check request didn't work: explanation with suggested actions

marcin-kwasniak · 2019-04-10T18:52:48Z

Hi, I made a correction for English, German and Polish.

…s-app#2874)" This reverts commit 174efe0.

* Avoid jargon and slang, change for default, de and pl (#2874) * Revert "Avoid jargon and slang, change for default, de and pl (#2874)" This reverts commit 174efe0. * check_category_success_title text changed to: Category check requested * check_category_failure_title new text

MitchellAugustin · 2019-10-05T04:23:02Z

Hello, I made some more corrections for English

neslihanturan · 2019-11-01T13:07:07Z

Reopened because the issue is not completely solved.

chaytanyasinha · 2019-11-09T12:17:01Z

May I contribute to this issue.

akonic · 2019-11-29T19:21:54Z

@neslihanturan What is left on this issue?

neslihanturan · 2019-11-29T19:25:49Z

You can search mentioned strings in strings.xml file and fix them as guided in the issue description.

a18jouan · 2019-12-11T13:54:06Z

I found the same problem with two others messages :
Sending Thanks: Failure
Sending Thanks : Success
Can I fix that ?

neslihanturan · 2019-12-16T10:31:41Z

Sure @a18jouan , it is yours:)

vibhusharma101 · 2020-01-23T10:21:14Z

can I Work on this issue if it is not solved yet?

neslihanturan · 2020-01-24T12:05:49Z

@a18jouan are you still working on this issue? If not @vibhusharma101 wants to take it.

avivith · 2020-03-11T20:33:40Z

Is this issue closed already? if not, what is left to be done?

FawziyahAlebiosu · 2020-03-19T22:00:13Z

correct me if I'm wrong, it looks like the remaining strings that still contain 'success and failure" are:

apps-android-commons/app/src/main/res/values/strings.xml

Line 22 in 0ad269d

<string name="login_success">Login success!</string>

apps-android-commons/app/src/main/res/values/strings.xml

Line 338 in 0ad269d

<string name="wallpaper_set_successfully">Wallpaper set successfully!</string>

apps-android-commons/app/src/main/res/values/strings.xml

Line 484 in 0ad269d

<string name="send_thank_success_title">Sending Thanks: Success</string>

Meanwhile there are a slew of other words that definitely still use the word 'failed' in user interactions. The link you included in your original post does not give more options on what to say instead of failure.
I can definitely understand how "file was not renamed... use a different name" is a good replacement for failure, but now I'm definitely going to start a running list on what to say in cases like:

someone does not login successfully or
authentication failed. etc

Any suggestions?

arishtajain14 · 2020-09-14T11:00:08Z

Can this issue be assigned to me and my team?

darshan934 · 2020-10-01T09:03:18Z

Hello,
Can I clean up the remaining parts of this?

neslihanturan · 2020-10-01T12:38:46Z

Thanks for your intersts @darshan934 , @arishta and @FawziyahAlebiosu . I think before start to implement some changes, we need to discuss what has left from this issue and how we should proceed.

harshsaver · 2020-10-04T18:19:40Z

Hello, if the issue has not yet been solved, I would like to work on it!

neslihanturan · 2020-10-05T06:44:18Z

Hello everyone seems interested, please make sure you noted the remained parts of the issue (ie. related strings) along with your request to work on it. I am not sure if the issue is solved or not and I would like to discuss before you start working on it.

arishtajain14 · 2020-10-05T08:48:47Z

@neslihanturan
As mentioned by @FawziyahAlebiosu , there are strings which still contain 'success and failure' that need to be replaced.
We could start with that.

neslihanturan · 2020-10-05T11:05:50Z

Seems like a good start @arishta , thanks! What kind of replacements do you suggest? If @FawziyahAlebiosu is not interested anymore, you can start to work on this issue (since you were the first interested person after FawziyahAlebiosu). Otherwise, @FawziyahAlebiosu can claim the issue.

arishtajain14 · 2020-10-05T13:15:15Z

Here are the replacements that I suggest for these strings :

Replace "Login success!" with "You are logged in!", the latter sounds more user friendly.
Replace "Wallpaper set successfully" with "Wallpaper set", since I think the word "successfully" is redundant here.
Replace "Sending Thanks : Success" with "Thanks Sent!".

neslihanturan · 2020-10-05T13:25:23Z

Sounds good to me:)

arishtajain14 · 2020-10-11T14:15:59Z

@neslihanturan since @FawziyahAlebiosu does not seem to be active on this issue, can it assigned to me so that I can start working on it.

neslihanturan · 2020-10-11T14:17:14Z

@neslihanturan since @FawziyahAlebiosu does not seem to be active on this issue, can it assigned to me so that I can start working on it.

Please go for it @arishta :)

arishtajain14 · 2020-10-27T21:28:43Z

@sivaraam My team has submitted a PR request from the user account : isdl03. Kindly review it.

sivaraam · 2020-10-28T17:55:09Z

Strangely, I don't see any PRs from the mentioned account. I only see PR #3991 for this issue which doesn't seem to be from the mentioned account. @arishta Could you share a link to the PR or clarify what I'm missing?

arishtajain14 · 2020-10-28T23:07:57Z

@sivaraam Here is the link to the PR : #4000

arishtajain14 · 2020-11-08T19:46:04Z

Here is the link to the PR submitted by my team isdl03
link

misaochan · 2020-11-09T09:52:10Z

It seems like changes were requested on #4000 . Is there a reason you created a 2nd PR?

arishtajain14 · 2020-11-09T10:40:23Z

A new member of our team started working on this issue and submitted a new PR. The changes should have been made in existing PR only. We will ensure this in the future.

AdityaArunSharma · 2020-11-30T19:25:25Z

@neslihanturan is this issue still open. Can i work on it?

misaochan · 2020-12-01T13:48:32Z

@arishta Would you /your teammate like to make the requested changes in #4000 ?

@AdityaArunSharma Thanks for your interest, but there is already a PR up for this (pending requested changes). :) If the owner of the PR doesn't make the changes, we can reassign it, but we should give them a bit more time. Please feel free to look for any other issues with the "bug" or "good first issue" label.

isdl03 · 2020-12-01T14:23:24Z

@misaochan Since we are working on two more issues from this app, there has been some delay. We will make the requested changes and submit the PR as soon as possible.
Thanks.

isdl03 · 2020-12-01T22:37:16Z

@misaochan We are unable to make the changes in the current PR #4024 . Is it alright if we create a new PR?

misaochan · 2020-12-02T09:43:34Z

Hi @isdl03 , it seems like this is the 3rd PR you are creating for fixing a small issue. Could you elaborate on the problems you are experiencing with just pushing your changes to the existing PR? Maybe we can help you.

isdl03 · 2020-12-03T15:11:13Z

@misaochan PR #4024 is showing changes in the complete file, and we could not get rid of these unnecessary changes.

sivaraam · 2020-12-03T17:59:21Z

@isdl03 PR #4000 didn't have unnecessary changes. So, you could try updating that.

arishtajain14 · 2021-01-09T09:38:33Z

We have made the changes as requested in the PR #4000.
Kindly review the same.

neslihanturan added good first issue user experience labels Apr 10, 2019

marcin-kwasniak pushed a commit to marcin-kwasniak/apps-android-commons that referenced this issue Apr 10, 2019

Avoid jargon and slang, change for default, de and pl (commons-app#2874)

174efe0

marcin-kwasniak mentioned this issue Apr 10, 2019

Avoid jargon and slang, change for default, de and pl (#2874) #2876

Merged

marcin-kwasniak pushed a commit to marcin-kwasniak/apps-android-commons that referenced this issue Apr 11, 2019

Revert "Avoid jargon and slang, change for default, de and pl (common…

b983a72

…s-app#2874)" This reverts commit 174efe0.

MitchellAugustin mentioned this issue Oct 5, 2019

Removed some jargon/slang from strings.xml #3162

Merged

neslihanturan closed this as completed in #3162 Nov 1, 2019

neslihanturan reopened this Nov 1, 2019

sivaraam mentioned this issue Oct 27, 2020

Erosa issue 2874 #3991

Closed

isdl03 mentioned this issue Nov 8, 2020

Changed the strings #4024

Closed

domdomegg mentioned this issue Jan 12, 2021

Fix #2874 shouldn't use the words "success" and "failure" #4000

Closed

"check category failure title" and "check category success title" shouldn't use the words "success" and "failure" #2874

"check category failure title" and "check category success title" shouldn't use the words "success" and "failure" #2874

Comments

amire80 commented Apr 10, 2019

marcin-kwasniak commented Apr 10, 2019

MitchellAugustin commented Oct 5, 2019

neslihanturan commented Nov 1, 2019

chaytanyasinha commented Nov 9, 2019

akonic commented Nov 29, 2019

neslihanturan commented Nov 29, 2019

a18jouan commented Dec 11, 2019

neslihanturan commented Dec 16, 2019

vibhusharma101 commented Jan 23, 2020

neslihanturan commented Jan 24, 2020

avivith commented Mar 11, 2020

FawziyahAlebiosu commented Mar 19, 2020

arishtajain14 commented Sep 14, 2020

darshan934 commented Oct 1, 2020

neslihanturan commented Oct 1, 2020

harshsaver commented Oct 4, 2020

neslihanturan commented Oct 5, 2020

arishtajain14 commented Oct 5, 2020

neslihanturan commented Oct 5, 2020

arishtajain14 commented Oct 5, 2020

neslihanturan commented Oct 5, 2020

arishtajain14 commented Oct 11, 2020

neslihanturan commented Oct 11, 2020 • edited Loading

arishtajain14 commented Oct 27, 2020

sivaraam commented Oct 28, 2020

arishtajain14 commented Oct 28, 2020

arishtajain14 commented Nov 8, 2020

misaochan commented Nov 9, 2020

arishtajain14 commented Nov 9, 2020

AdityaArunSharma commented Nov 30, 2020

misaochan commented Dec 1, 2020 • edited Loading

isdl03 commented Dec 1, 2020

isdl03 commented Dec 1, 2020

misaochan commented Dec 2, 2020

isdl03 commented Dec 3, 2020

sivaraam commented Dec 3, 2020

arishtajain14 commented Jan 9, 2021

neslihanturan commented Oct 11, 2020 •

edited

Loading

misaochan commented Dec 1, 2020 •

edited

Loading