Fixes #2882: Item name not filled in toast #2890
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2890 +/- ##
=========================================
+ Coverage 3.41% 3.62% +0.21%
=========================================
Files 246 246
Lines 12252 12210 -42
Branches 1080 1077 -3
=========================================
+ Hits 418 443 +25
+ Misses 11803 11733 -70
- Partials 31 34 +3
Continue to review full report at Codecov.
|
|
@ahmedmamdouh13 It would be nice if you add some information on which device and app flavor you tested :) |
| @@ -209,6 +209,7 @@ public void next() { | |||
| void setCurrentTitleAndDescriptions(Title title, List<Description> descriptions) { | |||
| setCurrentUploadTitle(title); | |||
| setCurrentUploadDescriptions(descriptions); | |||
| store.putString("Title",title.toString()); | |||
There was a problem hiding this comment.
Java developers have the habit of adding a space after the comma, would you mind adding it?
More about the coding style: https://github.com/commons-app/apps-android-commons/wiki/Code-style
You can commit and push the same branch, it will automatically update your pull request. Thanks :-)
|
Would you mind posting a screenshot showing the fixed result? Thanks :-) |
|
Thank you all for your patience ! |
…b does not show" This reverts commit 3e44986
Description
Put item name into sharedPreferences to fix Toast in edit wikidata issue.
item name wasn't displayed in the Toast of successful wikidata editing operation
Fixes #2882 Item name not filled in toast
What changes did you make and why?
-put item name into sharedPreferences in UploadModel class , to fix Toast display from the WikiDataEditService class.
Tests Performed
...